Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

Merged
merged 16 commits into from
Feb 22, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Feb 19, 2025

Fix a couple things I noticed while finalizing the docs PR: getsentry/sentry-docs#11191 and would like to fix before officially releasing the feature for the first time

#skip-changelog

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.200%. Comparing base (d33f2c8) to head (844e7a0).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...UserFeedback/SentryUserFeedbackFormViewModel.swift 50.000% 6 Missing ⚠️
...ift/Integrations/UserFeedback/SentryFeedback.swift 85.714% 2 Missing ⚠️
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% 2 Missing ⚠️
Sources/Sentry/SentryClient.m 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4873       +/-   ##
=============================================
- Coverage   92.257%   92.200%   -0.058%     
=============================================
  Files          659       659               
  Lines        77310     77526      +216     
  Branches     27933     27282      -651     
=============================================
+ Hits         71324     71479      +155     
- Misses        5890      5955       +65     
+ Partials        96        92        -4     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySDK.m 88.288% <ø> (+0.674%) ⬆️
...onfiguration/SentryUserFeedbackConfiguration.swift 53.333% <ø> (-1.506%) ⬇️
...guration/SentryUserFeedbackFormConfiguration.swift 100.000% <100.000%> (ø)
...uration/SentryUserFeedbackThemeConfiguration.swift 82.352% <100.000%> (ø)
...ts/Integrations/Feedback/SentryFeedbackTests.swift 97.633% <100.000%> (+0.531%) ⬆️
Sources/Sentry/SentryClient.m 95.184% <0.000%> (ø)
...ift/Integrations/UserFeedback/SentryFeedback.swift 72.727% <85.714%> (+5.380%) ⬆️
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% <0.000%> (ø)
...UserFeedback/SentryUserFeedbackFormViewModel.swift 84.634% <50.000%> (-0.726%) ⬇️

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33f2c8...844e7a0. Read the comment docs.

Copy link

github-actions bot commented Feb 19, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.51 ms 1244.23 ms 13.72 ms
Size 22.31 KiB 821.95 KiB 799.64 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7fb7afb 1230.12 ms 1251.04 ms 20.92 ms
b8dd0fc 1268.96 ms 1271.90 ms 2.94 ms
2b19b82 1237.45 ms 1256.60 ms 19.16 ms
c76f9b0 1249.78 ms 1265.14 ms 15.36 ms
e8b2fb4 1230.70 ms 1242.84 ms 12.14 ms
bee3e88 1232.65 ms 1247.33 ms 14.68 ms
2862f33 1208.83 ms 1227.29 ms 18.45 ms
5d6ce0e 1206.72 ms 1228.67 ms 21.95 ms
aa27ac0 1214.02 ms 1227.42 ms 13.40 ms
eae2b59 1229.62 ms 1251.83 ms 22.21 ms

App size

Revision Plain With Sentry Diff
7fb7afb 20.76 KiB 419.70 KiB 398.94 KiB
b8dd0fc 20.76 KiB 401.39 KiB 380.63 KiB
2b19b82 21.58 KiB 542.19 KiB 520.61 KiB
c76f9b0 22.85 KiB 406.69 KiB 383.84 KiB
e8b2fb4 20.76 KiB 427.23 KiB 406.46 KiB
bee3e88 22.30 KiB 749.95 KiB 727.64 KiB
2862f33 22.31 KiB 775.17 KiB 752.86 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
aa27ac0 20.76 KiB 432.21 KiB 411.45 KiB
eae2b59 21.58 KiB 705.31 KiB 683.72 KiB

Previous results on branch: armcknight/feat(feedback)/final-fixes

Startup times

Revision Plain With Sentry Diff
e8689b8 1233.73 ms 1247.82 ms 14.08 ms
5baa4a5 1227.49 ms 1245.43 ms 17.94 ms
f09e892 1220.22 ms 1238.80 ms 18.57 ms
38ae188 1221.04 ms 1246.91 ms 25.87 ms
d91d45e 1230.89 ms 1253.00 ms 22.11 ms
cc14e49 1209.31 ms 1231.54 ms 22.24 ms

App size

Revision Plain With Sentry Diff
e8689b8 22.31 KiB 822.17 KiB 799.87 KiB
5baa4a5 22.31 KiB 821.57 KiB 799.26 KiB
f09e892 22.31 KiB 820.98 KiB 798.67 KiB
38ae188 22.31 KiB 820.94 KiB 798.63 KiB
d91d45e 22.31 KiB 822.18 KiB 799.87 KiB
cc14e49 22.31 KiB 821.57 KiB 799.26 KiB

@armcknight armcknight marked this pull request as draft February 20, 2025 08:31
@armcknight armcknight marked this pull request as ready for review February 20, 2025 17:47
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it 50% of the PR, only 1 question

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but other than that LGTM

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few suggestions.

@armcknight armcknight merged commit 9798947 into main Feb 22, 2025
70 of 74 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/final-fixes branch February 22, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants