-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): last minute tweaks to apis to align implementation and docs #4873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4873 +/- ##
=============================================
- Coverage 92.257% 92.200% -0.058%
=============================================
Files 659 659
Lines 77310 77526 +216
Branches 27933 27282 -651
=============================================
+ Hits 71324 71479 +155
- Misses 5890 5955 +65
+ Partials 96 92 -4
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fb7afb | 1230.12 ms | 1251.04 ms | 20.92 ms |
b8dd0fc | 1268.96 ms | 1271.90 ms | 2.94 ms |
2b19b82 | 1237.45 ms | 1256.60 ms | 19.16 ms |
c76f9b0 | 1249.78 ms | 1265.14 ms | 15.36 ms |
e8b2fb4 | 1230.70 ms | 1242.84 ms | 12.14 ms |
bee3e88 | 1232.65 ms | 1247.33 ms | 14.68 ms |
2862f33 | 1208.83 ms | 1227.29 ms | 18.45 ms |
5d6ce0e | 1206.72 ms | 1228.67 ms | 21.95 ms |
aa27ac0 | 1214.02 ms | 1227.42 ms | 13.40 ms |
eae2b59 | 1229.62 ms | 1251.83 ms | 22.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
b8dd0fc | 20.76 KiB | 401.39 KiB | 380.63 KiB |
2b19b82 | 21.58 KiB | 542.19 KiB | 520.61 KiB |
c76f9b0 | 22.85 KiB | 406.69 KiB | 383.84 KiB |
e8b2fb4 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
bee3e88 | 22.30 KiB | 749.95 KiB | 727.64 KiB |
2862f33 | 22.31 KiB | 775.17 KiB | 752.86 KiB |
5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
aa27ac0 | 20.76 KiB | 432.21 KiB | 411.45 KiB |
eae2b59 | 21.58 KiB | 705.31 KiB | 683.72 KiB |
Previous results on branch: armcknight/feat(feedback)/final-fixes
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e8689b8 | 1233.73 ms | 1247.82 ms | 14.08 ms |
5baa4a5 | 1227.49 ms | 1245.43 ms | 17.94 ms |
f09e892 | 1220.22 ms | 1238.80 ms | 18.57 ms |
38ae188 | 1221.04 ms | 1246.91 ms | 25.87 ms |
d91d45e | 1230.89 ms | 1253.00 ms | 22.11 ms |
cc14e49 | 1209.31 ms | 1231.54 ms | 22.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e8689b8 | 22.31 KiB | 822.17 KiB | 799.87 KiB |
5baa4a5 | 22.31 KiB | 821.57 KiB | 799.26 KiB |
f09e892 | 22.31 KiB | 820.98 KiB | 798.67 KiB |
38ae188 | 22.31 KiB | 820.94 KiB | 798.63 KiB |
d91d45e | 22.31 KiB | 822.18 KiB | 799.87 KiB |
cc14e49 | 22.31 KiB | 821.57 KiB | 799.26 KiB |
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackFormConfiguration.swift
Show resolved
Hide resolved
...ces/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackThemeConfiguration.swift
Show resolved
Hide resolved
...ces/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackThemeConfiguration.swift
Show resolved
Hide resolved
...ces/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackThemeConfiguration.swift
Show resolved
Hide resolved
...ces/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackThemeConfiguration.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it 50% of the PR, only 1 question
Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackConfiguration.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, but other than that LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few suggestions.
Fix a couple things I noticed while finalizing the docs PR: getsentry/sentry-docs#11191 and would like to fix before officially releasing the feature for the first time
#skip-changelog