Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

Merged
merged 16 commits into from
Feb 22, 2025

rename to something nonstandard

844e7a0
Select commit
Loading
Failed to load commit list.
Merged

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

rename to something nonstandard
844e7a0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Feb 21, 2025 in 1s

84.507% of diff hit (target 92.257%)

View this Pull Request on Codecov

84.507% of diff hit (target 92.257%)

Annotations

Check warning on line 620 in Sources/Sentry/SentryClient.m

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentryClient.m#L620 

Added line #L620 was not covered by tests

Check warning on line 79 in Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift#L79 

Added line #L79 was not covered by tests

Check warning on line 345 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift#L345 

Added line #L345 was not covered by tests

Check warning on line 459 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift#L459 

Added line #L459 was not covered by tests

Check warning on line 461 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift#L461 

Added line #L461 was not covered by tests

Check warning on line 170 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidgetButtonView.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidgetButtonView.swift#L170 

Added line #L170 was not covered by tests

Check warning on line 173 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidgetButtonView.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidgetButtonView.swift#L173 

Added line #L173 was not covered by tests
View more details on Codecov