Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Jun 26, 2025

#skip-changelog

Use vars in ui-tests-common.yml run commands

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1201.92 ms 1235.36 ms 33.45 ms
Size 23.75 KiB 867.16 KiB 843.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
35c962f 1207.61 ms 1235.90 ms 28.29 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
8047b99 1226.37 ms 1246.63 ms 20.26 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
f97a070 1218.88 ms 1253.12 ms 34.24 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
b13e93a 1236.24 ms 1247.33 ms 11.08 ms
db9572a 1200.27 ms 1234.80 ms 34.53 ms

App size

Revision Plain With Sentry Diff
35c962f 23.75 KiB 854.77 KiB 831.02 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
8047b99 23.75 KiB 855.37 KiB 831.62 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
f97a070 23.75 KiB 858.68 KiB 834.93 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
b13e93a 23.75 KiB 855.37 KiB 831.62 KiB
db9572a 23.75 KiB 858.69 KiB 834.93 KiB

@denrase denrase marked this pull request as ready for review June 26, 2025 13:31
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cause this fixes code vulnerabilities. Next time please include this in the PR description @denrase, then I approve straight away 😄

@denrase
Copy link
Collaborator Author

denrase commented Jun 30, 2025

@philipphofmann Sry, was nor sure if i can mention it due to the nature of the vulnerability.

@denrase denrase merged commit ee700c5 into main Jun 30, 2025
84 of 87 checks passed
@denrase denrase deleted the chore/use-vars-in-env-commands-pt-2 branch June 30, 2025 13:32
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants