Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Jul 29, 2025

The "integrations" options would print a warning message saying it was deprecated every time it was used. To make this a bit more user friendly I converted it to an actual deprecation attribute.

Also removed the option entirely from V9 since it is deprecated.

@codecov
Copy link

codecov bot commented Jul 29, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
31381 1 31380 97
View the top 2 failed test(s) by shortest run time
SentryCrashReportStore_Tests::testPruneReports
Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryCrashReportStore_Tests.m:126 - ((sentrycrashcrs_getReportCount()) equal to (reportCount)) failed: ("7") is not equal to ("8")
SentryTracerTests::testConcurrentTransactions_OnlyOneGetsMeasurement
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryTracerTests.testConcurrentTransactions_OnlyOneGetsMeasurement(); summary will include totals from previous launches.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.49 ms 1241.90 ms 28.41 ms
Size 23.75 KiB 908.43 KiB 884.68 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a2a3bfb 1227.94 ms 1261.26 ms 33.32 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms
c585b1e 1232.88 ms 1249.45 ms 16.58 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
bbe6658 1221.00 ms 1248.51 ms 27.51 ms
bce9765 1229.42 ms 1243.49 ms 14.07 ms
134fbdf 1219.71 ms 1240.35 ms 20.64 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
0529194 1237.23 ms 1254.67 ms 17.44 ms
42cfd79 1222.13 ms 1244.23 ms 22.10 ms

App size

Revision Plain With Sentry Diff
a2a3bfb 23.75 KiB 872.67 KiB 848.92 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB
c585b1e 23.75 KiB 879.95 KiB 856.21 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
bbe6658 23.75 KiB 908.02 KiB 884.27 KiB
bce9765 23.74 KiB 874.06 KiB 850.32 KiB
134fbdf 23.75 KiB 875.25 KiB 851.50 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
0529194 23.74 KiB 891.02 KiB 867.28 KiB
42cfd79 23.75 KiB 880.20 KiB 856.45 KiB

Previous results on branch: deprecateIntegrations

Startup times

Revision Plain With Sentry Diff
6918fcd 1232.26 ms 1234.21 ms 1.95 ms

App size

Revision Plain With Sentry Diff
6918fcd 23.75 KiB 908.44 KiB 884.69 KiB

@noahsmartin noahsmartin force-pushed the deprecateIntegrations branch from 4f9ee67 to 894e4ac Compare July 29, 2025 13:44
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, good catch thank you.

@noahsmartin noahsmartin merged commit fae97e5 into main Jul 30, 2025
137 of 143 checks passed
@noahsmartin noahsmartin deleted the deprecateIntegrations branch July 30, 2025 15:47
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants