Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Aug 8, 2025

Fixes yaml using yes instead of true

#skip-changelog

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.652%. Comparing base (50a9ff7) to head (faaa459).
⚠️ Report is 20 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5862       +/-   ##
=============================================
- Coverage   86.674%   86.652%   -0.022%     
=============================================
  Files          423       423               
  Lines        36405     36405               
  Branches     17231     17228        -3     
=============================================
- Hits         31554     31546        -8     
- Misses        4805      4814        +9     
+ Partials        46        45        -1     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a9ff7...faaa459. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have a reference to documentation explaining the difference between yes and true?

@itaybre
Copy link
Contributor Author

itaybre commented Aug 11, 2025

LGTM. Do we have a reference to documentation explaining the difference between yes and true?

YAML 1.1 accepts yes as true.
But YAML 1.2 doesn't accept it anymore, seems like codecov plugin for cursor uses that version.

So in theory it is supported but true is preferred

@philprime
Copy link
Member

Thanks for the note, lgtm 👍

@itaybre itaybre merged commit efa740d into main Aug 12, 2025
24 of 25 checks passed
@itaybre itaybre deleted the itaybre/fix_codecov_config branch August 12, 2025 12:36
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants