Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 17, 2025

This needed some refactoring to be used in the Swift dependency container. Rather than using a protocol, it now uses a class that wraps the objc implementation.

#skip-changelog

Closes #6451

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.011%. Comparing base (94de2d3) to head (239e637).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SentryDefaultUIViewControllerPerformanceTracker.m 90.000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6450       +/-   ##
=============================================
+ Coverage   86.961%   87.011%   +0.049%     
=============================================
  Files          449       449               
  Lines        37728     37772       +44     
  Branches     17461     17481       +20     
=============================================
+ Hits         32809     32866       +57     
+ Misses        4876      4863       -13     
  Partials        43        43               
Files with missing lines Coverage Δ
Sources/Sentry/SentryDependencyContainer.m 90.295% <100.000%> (-0.082%) ⬇️
...rces/Sentry/SentryPerformanceTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryUIViewControllerSwizzling.m 92.000% <100.000%> (ø)
...nce/SentryUIViewControllerPerformanceTracker.swift 100.000% <100.000%> (ø)
.../SentryDefaultUIViewControllerPerformanceTracker.m 97.964% <90.000%> (-1.018%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94de2d3...239e637. Read the comment docs.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the refactorPerformanceTrackerSwift branch from b58e9fa to 6ba7deb Compare October 17, 2025 17:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.22 ms 1268.08 ms 33.86 ms
Size 23.75 KiB 1019.18 KiB 995.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e446901 1233.32 ms 1252.32 ms 19.00 ms
7d88965 1228.86 ms 1248.53 ms 19.67 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
b5a7583 1238.22 ms 1263.94 ms 25.71 ms
efa740d 1220.71 ms 1246.20 ms 25.50 ms
3cdbc22 1231.63 ms 1251.06 ms 19.43 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms
162cd7f 1230.59 ms 1256.76 ms 26.16 ms
3067c23 1230.48 ms 1257.90 ms 27.42 ms

App size

Revision Plain With Sentry Diff
e446901 23.75 KiB 933.33 KiB 909.58 KiB
7d88965 23.75 KiB 994.72 KiB 970.98 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
b5a7583 23.75 KiB 913.44 KiB 889.68 KiB
efa740d 23.75 KiB 919.69 KiB 895.95 KiB
3cdbc22 23.75 KiB 928.14 KiB 904.40 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB
162cd7f 23.75 KiB 908.39 KiB 884.64 KiB
3067c23 23.75 KiB 928.15 KiB 904.40 KiB

Previous results on branch: refactorPerformanceTrackerSwift

Startup times

Revision Plain With Sentry Diff
343a8ba 1220.98 ms 1253.74 ms 32.76 ms

App size

Revision Plain With Sentry Diff
343a8ba 23.75 KiB 1017.47 KiB 993.72 KiB

@noahsmartin noahsmartin force-pushed the refactorPerformanceTrackerSwift branch 3 times, most recently from 21a3024 to 2a4285b Compare October 17, 2025 19:06
@noahsmartin noahsmartin force-pushed the refactorPerformanceTrackerSwift branch from 2a4285b to 239e637 Compare October 17, 2025 19:10
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryUIViewControllerSwizzling.m

@noahsmartin noahsmartin merged commit aac24ac into main Oct 17, 2025
181 checks passed
@noahsmartin noahsmartin deleted the refactorPerformanceTrackerSwift branch October 17, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Refactor performance tracker swift version

3 participants