-
-
Notifications
You must be signed in to change notification settings - Fork 372
ref: Refactor performance tracker swift version #6450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6450 +/- ##
=============================================
+ Coverage 86.961% 87.011% +0.049%
=============================================
Files 449 449
Lines 37728 37772 +44
Branches 17461 17481 +20
=============================================
+ Hits 32809 32866 +57
+ Misses 4876 4863 -13
Partials 43 43
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b58e9fa to
6ba7deb
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e446901 | 1233.32 ms | 1252.32 ms | 19.00 ms |
| 7d88965 | 1228.86 ms | 1248.53 ms | 19.67 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| b5a7583 | 1238.22 ms | 1263.94 ms | 25.71 ms |
| efa740d | 1220.71 ms | 1246.20 ms | 25.50 ms |
| 3cdbc22 | 1231.63 ms | 1251.06 ms | 19.43 ms |
| ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
| d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
| 162cd7f | 1230.59 ms | 1256.76 ms | 26.16 ms |
| 3067c23 | 1230.48 ms | 1257.90 ms | 27.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e446901 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 7d88965 | 23.75 KiB | 994.72 KiB | 970.98 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| b5a7583 | 23.75 KiB | 913.44 KiB | 889.68 KiB |
| efa740d | 23.75 KiB | 919.69 KiB | 895.95 KiB |
| 3cdbc22 | 23.75 KiB | 928.14 KiB | 904.40 KiB |
| ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
| d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| 162cd7f | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| 3067c23 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
21a3024 to
2a4285b
Compare
2a4285b to
239e637
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This needed some refactoring to be used in the Swift dependency container. Rather than using a protocol, it now uses a class that wraps the objc implementation.
#skip-changelog
Closes #6451