-
-
Notifications
You must be signed in to change notification settings - Fork 372
test(session-replay): Add masking tests for edge cases #6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added expectations to verify the animation state during redaction, ensuring the position of the masked region is within the expected range during animation. This improves the robustness of the edge case tests for UI redaction.
…se tests Updated the animation duration and expectations in the edge case tests for UI redaction. The assertions now verify that the position of the masked region is approximately at the midpoint of the animation, enhancing the accuracy of the tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6569 +/- ##
=============================================
+ Coverage 85.471% 85.510% +0.039%
=============================================
Files 451 451
Lines 27566 27565 -1
Branches 12071 12070 -1
=============================================
+ Hits 23561 23571 +10
+ Misses 3958 3949 -9
+ Partials 47 45 -2 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Merge activity
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 827b50c | 1233.27 ms | 1267.28 ms | 34.01 ms |
| 8745cc0 | 1228.13 ms | 1250.48 ms | 22.35 ms |
| ebc72be | 1221.24 ms | 1249.66 ms | 28.42 ms |
| 8ad303c | 1220.02 ms | 1231.79 ms | 11.77 ms |
| 331dad6 | 1210.40 ms | 1242.06 ms | 31.67 ms |
| 2bddb03 | 1214.11 ms | 1246.78 ms | 32.67 ms |
| 916edbe | 1243.86 ms | 1256.11 ms | 12.25 ms |
| 3b4b557 | 1234.59 ms | 1254.02 ms | 19.43 ms |
| b074ba9 | 1236.52 ms | 1248.75 ms | 12.23 ms |
| 25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 827b50c | 23.75 KiB | 1.00 MiB | 1005.07 KiB |
| 8745cc0 | 23.74 KiB | 971.81 KiB | 948.07 KiB |
| ebc72be | 23.75 KiB | 908.22 KiB | 884.47 KiB |
| 8ad303c | 23.75 KiB | 879.24 KiB | 855.49 KiB |
| 331dad6 | 23.75 KiB | 928.12 KiB | 904.37 KiB |
| 2bddb03 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| 916edbe | 23.75 KiB | 908.41 KiB | 884.66 KiB |
| 3b4b557 | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| b074ba9 | 23.74 KiB | 976.79 KiB | 953.05 KiB |
| 25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
|
After feedback from @noahsmartin I need to remove unnecessary snapshots before merging |
Pull request was converted to draft
|
I removed the snapshot testing so this can get merged without bloating the repo more. |
…in (#6678) * fix(session-replay): Update rendering method for fast view rendering (#6360) * fix(session-replay): Extend masking and focus masking on sensitive information (#6292) * test(session-replay): Add masking tests for common cases (#6567) * test(session-replay): Add masking tests for React Native views (#6568) * fix(session-replay): Fix conversion of frame rate to time interval (#6623) * test(session-replay): Add masking tests for edge cases (#6569) * test(session-replay): Add masking tests for UIKit views (#6570) * test(session-replay): Add masking tests for special views (#6571) * fix(session-replay): Include layer background color when checking if a view is opaque (#6629) * chore(tests): Remove snapshot testing to reduce repository size (#6631) * chore: Remove unwanted CHANGELOG entries from cherry-pick - Remove #5591 (minimum OS version warnings) - not related to session replay - Remove #6019 (SCNetworkReachability) - not related to session replay - Remove #6377 (thread event issue) - not related to session replay - Remove #6381 (frame delay) - duplicate/not related to session replay - Keep only session replay masking related changes * docs: Move changelog changes from v8.57.1 to unreleased * test: Resolve wrong assertions involed due to merge-conflict * chore: Update sdk_api_V9.json

Derived from #6292 for stacked merging
#skip-changelog