-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Introduce Hint
data bag
#1136
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Introduce `Hint` data bag ([#1136](https://github.com/getsentry/sentry-dart/pull/1136)) If none of the above apply, you can opt out of this check by adding |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1136 +/- ##
=========================================
Coverage ? 88.07%
=========================================
Files ? 121
Lines ? 3815
Branches ? 0
=========================================
Hits ? 3360
Misses ? 455
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@denrase so one thing that has to be done is, the SDK should create a |
Btw before merging this, I believe we need to update the branch v7.0.0 with the latest main to avoid more conflicts. |
@marandaneto Hope i found all occurences where we can pass a hint. Made an expeption (pun!) to exceptions and stacktraces, as they are already passed. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments but overall LGTM
📜 Description
Introduces a custom type for all
hint properties
, with aMap
like interface.Relates to #510
💡 Motivation and Context
Users can attach more than one primitive or object to API which takes a
hint
parameter.This is a breaking change.
💚 How did you test it?
Added unit tests.
📝 Checklist
🔮 Next steps
I have opted not to add
Attachments
orScreenshot
to the scope of this PR. Should we do this separately and also define what to do with this data in the SDK?