Allow attachments to be bound to exception more easily #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzyzcjy
requested review from
brustolin,
denrase and
marandaneto
as code owners
Codecov ReportBase: 89.47% // Head: 89.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 89.47% 89.46% -0.01%
==========================================
Files 106 106
Lines 3326 3333 +7
==========================================
+ Hits 2976 2982 +6
- Misses 350 351 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…getsentry-main # Conflicts: # dart/lib/src/sentry_options.dart
# Conflicts: # dart/lib/src/hub.dart
|
#1136 is going to enable this type of feature, which is passing or removing attachments from the hint. |
|
Closing, the new approach should use hints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs #682