Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: windows native error & obfuscation support #2286

Merged
merged 67 commits into from
Oct 10, 2024
Merged

feat: windows native error & obfuscation support #2286

merged 67 commits into from
Oct 10, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Sep 12, 2024 •
edited
Loading

📜 Description

This adds support for:

  • catching native crashes on Windows
  • server-side symbolication of obfuscated dart errors on Windows

💡 Motivation and Context

💚 How did you test it?

Added tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

vaind added 29 commits August 21, 2024 14:09
@vaind
chore: update windows code based on latest flutter template with plug…
be5f950 
…in_ffi
@vaind
feat: add sentry-native library to the windows build
f88531c
@vaind
add sentry-native bindings
4341827
@vaind
basic tests
588c047
@vaind
more native binding functions
4fea4b9
@vaind
improve native tests
cac80c3
@vaind
more native binding calls
dd8d1e6
@vaind
load debug image list
50fd16c
@vaind
add native feature support flags
852a306
@vaind
clean
db797f9
@vaind
Merge branch 'main' into feat/windows-native
98c7913
@vaind
update native crash example
9a82b38
@vaind
Merge branch 'main' into feat/windows-native
e2e2841
@vaind
post-merge fixup
cede7cd
@vaind
example: allways show console in the windows sample app
bdedccf
@vaind
fix: windows build with crashpad
0d07f97
@vaind
update test script
0ff707b
@vaind
tmp
e258718
@vaind
tmp
8fc78fd
@vaind
tmp
6cb6c2b
@vaind
remove cmake_minimum_required
4e9da9e
@vaind
windows native obfuscated stack trace support
00692fc
@vaind
move native debug image resolution to sentry_native.dart
f70dbbb
@vaind
fix native test setup
7ab7ff0
@vaind
further improve native test build
b516961
@vaind
update debug id conversion code
9a7f1a9
@vaind
fix native init test
9fb0c2a
@vaind
Merge branch 'main' into feat/windows-native
5cb2338
@vaind
test fixes
2f093db
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1b6bc60

@vaind vaind marked this pull request as ready for review September 20, 2024 15:06
@vaind vaind mentioned this pull request Apr 3, 2024
Closed
3 tasks
buenaflor
buenaflor reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good 👍

since this is a big PR I'll do another pass later

dart/lib/src/protocol/sentry_stack_frame.dart Show resolved Hide resolved
buenaflor
buenaflor approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@vaind vaind merged commit 20926fc into main Oct 10, 2024
122 checks passed
@vaind vaind deleted the feat/windows-native branch October 10, 2024 11:02
@vaind vaind mentioned this pull request Oct 16, 2024
Closed
@vaind vaind mentioned this pull request Nov 21, 2024
Merged
6 tasks
@buenaflor buenaflor mentioned this pull request Dec 10, 2024
Open
@kahest kahest mentioned this pull request Dec 12, 2024
Closed
@vaind vaind mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto left review comments

@buenaflor buenaflor buenaflor approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@martinhaintz martinhaintz Awaiting requested review from martinhaintz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaind @marandaneto @buenaflor