fix: load contexts not setting the user for transactions #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
krystofwoldrich,
stefanosiano and
martinhaintz
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 85.02% 85.89% +0.86%
==========================================
Files 257 242 -15
Lines 9175 8733 -442
==========================================
- Hits 7801 7501 -300
+ Misses 1374 1232 -142 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5b744f | 302.70 ms | 342.17 ms | 39.47 ms |
| 0ac1eed | 370.60 ms | 441.54 ms | 70.94 ms |
| 90a08ea | 477.25 ms | 534.10 ms | 56.85 ms |
| 0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
| 061fed2 | 434.11 ms | 506.49 ms | 72.38 ms |
| 4829ad3 | 381.55 ms | 455.45 ms | 73.90 ms |
| 519423f | 357.00 ms | 415.77 ms | 58.77 ms |
| ddc97ad | 331.45 ms | 384.06 ms | 52.61 ms |
| e3ef570 | 389.71 ms | 459.16 ms | 69.45 ms |
| 2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5b744f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 0ac1eed | 6.06 MiB | 7.03 MiB | 990.44 KiB |
| 90a08ea | 6.49 MiB | 7.55 MiB | 1.06 MiB |
| 0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 061fed2 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 4829ad3 | 6.33 MiB | 7.26 MiB | 943.11 KiB |
| 519423f | 6.06 MiB | 7.03 MiB | 989.24 KiB |
| ddc97ad | 6.16 MiB | 7.14 MiB | 1003.75 KiB |
| e3ef570 | 6.33 MiB | 7.26 MiB | 950.38 KiB |
| 2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
romtsn
approved these changes
Nov 11, 2024
martinhaintz
added a commit
that referenced
this pull request
Nov 12, 2024
…github.com/getsentry/sentry-dart into feat/redact-screenshots-via-view-hierarchy * 'feat/redact-screenshots-via-view-hierarchy' of https://github.com/getsentry/sentry-dart: build(deps): bump ruby/setup-ruby from 1.199.0 to 1.202.0 (#2403) Remove `sentry` frames if SDK falls back to current stack trace (#2351) fix: load contexts not setting the user for transactions (#2395) feat: improve frame tracking accuracy (#2372) build(sample): update kotlin version (#2398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Applies the fix introduced in #2089 to transactions as well
💡 Motivation and Context
Relates to #2089
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps