Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(sample): update kotlin version #2398

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 8, 2024

helps us catch any kotlin api issues when we build the sample

#skip-changelog

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (73992eb) to head (b5ce816).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
+ Coverage   84.72%   84.84%   +0.11%     
==========================================
  Files         254       79     -175     
  Lines        9113     2804    -6309     
==========================================
- Hits         7721     2379    -5342     
+ Misses       1392      425     -967     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 471.27 ms 513.14 ms 41.87 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5b744f 302.70 ms 342.17 ms 39.47 ms
0ac1eed 370.60 ms 441.54 ms 70.94 ms
90a08ea 477.25 ms 534.10 ms 56.85 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
061fed2 434.11 ms 506.49 ms 72.38 ms
4829ad3 381.55 ms 455.45 ms 73.90 ms
519423f 357.00 ms 415.77 ms 58.77 ms
ddc97ad 331.45 ms 384.06 ms 52.61 ms
e3ef570 389.71 ms 459.16 ms 69.45 ms
2d3b03d 309.53 ms 353.40 ms 43.87 ms

App size

Revision Plain With Sentry Diff
e5b744f 6.06 MiB 7.09 MiB 1.03 MiB
0ac1eed 6.06 MiB 7.03 MiB 990.44 KiB
90a08ea 6.49 MiB 7.55 MiB 1.06 MiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
061fed2 6.52 MiB 7.59 MiB 1.06 MiB
4829ad3 6.33 MiB 7.26 MiB 943.11 KiB
519423f 6.06 MiB 7.03 MiB 989.24 KiB
ddc97ad 6.16 MiB 7.14 MiB 1003.75 KiB
e3ef570 6.33 MiB 7.26 MiB 950.38 KiB
2d3b03d 6.06 MiB 7.09 MiB 1.03 MiB

@buenaflor buenaflor marked this pull request as ready for review November 8, 2024 15:14
@buenaflor buenaflor merged commit 15868f3 into main Nov 11, 2024
51 of 52 checks passed
@buenaflor buenaflor deleted the build/update-sample-kotlin branch November 11, 2024 12:57
martinhaintz added a commit that referenced this pull request Nov 12, 2024
…github.com/getsentry/sentry-dart into feat/redact-screenshots-via-view-hierarchy

* 'feat/redact-screenshots-via-view-hierarchy' of https://github.com/getsentry/sentry-dart:
  build(deps): bump ruby/setup-ruby from 1.199.0 to 1.202.0 (#2403)
  Remove `sentry` frames if SDK falls back to current stack trace (#2351)
  fix: load contexts not setting the user for transactions (#2395)
  feat: improve frame tracking accuracy (#2372)
  build(sample): update kotlin version (#2398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants