feat: add an option to configure native backend on windows & linux #2522
+364
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel/8.11.2 #2522 +/- ##
==============================================
+ Coverage 86.85% 92.17% +5.32%
==============================================
Files 260 84 -176
Lines 9240 2902 -6338
==============================================
- Hits 8025 2675 -5350
+ Misses 1215 227 -988 ☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9fe67d5 | 1242.33 ms | 1268.77 ms | 26.44 ms |
| a775d3f | 1241.29 ms | 1241.53 ms | 0.24 ms |
| 103eb14 | 1254.11 ms | 1280.65 ms | 26.55 ms |
| 754cdbe | 1261.67 ms | 1280.88 ms | 19.20 ms |
| 408bdab | 1239.63 ms | 1257.61 ms | 17.98 ms |
| fbf42af | 1253.76 ms | 1269.51 ms | 15.76 ms |
| c73ab67 | 1267.73 ms | 1279.36 ms | 11.63 ms |
| 99704d2 | 1241.74 ms | 1258.00 ms | 16.26 ms |
| bd1b990 | 1209.43 ms | 1226.96 ms | 17.53 ms |
| 4c13d97 | 1265.41 ms | 1287.95 ms | 22.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9fe67d5 | 8.32 MiB | 9.50 MiB | 1.18 MiB |
| a775d3f | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 103eb14 | 8.38 MiB | 9.71 MiB | 1.34 MiB |
| 754cdbe | 8.29 MiB | 9.37 MiB | 1.08 MiB |
| 408bdab | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| fbf42af | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| c73ab67 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 99704d2 | 8.42 MiB | 9.87 MiB | 1.44 MiB |
| bd1b990 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| 4c13d97 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1cdcacf | 389.94 ms | 463.53 ms | 73.59 ms |
| be08ed1 | 361.37 ms | 414.84 ms | 53.47 ms |
| 3ad66e4 | 406.90 ms | 481.48 ms | 74.58 ms |
| ad69abc | 297.35 ms | 385.89 ms | 88.54 ms |
| ef6466d | 373.96 ms | 443.17 ms | 69.21 ms |
| e893df5 | 310.60 ms | 380.58 ms | 69.98 ms |
| f25f207 | 341.40 ms | 427.73 ms | 86.34 ms |
| 61e71ec | 343.94 ms | 410.59 ms | 66.66 ms |
| 1131914 | 317.90 ms | 361.58 ms | 43.69 ms |
| fe4aa56 | 356.06 ms | 428.67 ms | 72.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1cdcacf | 6.33 MiB | 7.26 MiB | 949.77 KiB |
| be08ed1 | 6.33 MiB | 7.26 MiB | 946.42 KiB |
| 3ad66e4 | 6.33 MiB | 7.26 MiB | 947.04 KiB |
| ad69abc | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| ef6466d | 6.34 MiB | 7.28 MiB | 967.79 KiB |
| e893df5 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| f25f207 | 6.33 MiB | 7.26 MiB | 943.41 KiB |
| 61e71ec | 6.34 MiB | 7.28 MiB | 966.26 KiB |
| 1131914 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| fe4aa56 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
buenaflor
approved these changes
Dec 19, 2024
vaind
force-pushed
the
feat/native-backend-config
branch
from
388ea91 to
a42d4a2
Compare
buenaflor
reviewed
Dec 19, 2024
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Since v8.11.0 was released, there were a couple of issues reported with builds breaking. All of these were about a crashpad backend (which is the default one).
Because the change was introduced in a minor release, we shouldn't have a breaking change and we're making a native crash handler an opt-in.
Also, because we the reported issues were about building the backend, we're only changing that part of the native integration, while still leaving obfuscation support untouched.
What this PR effectively does:
SENTRY_NATIVE_BACKENDenv var that is picked up during build (can be one ofcrashpad, breakpad, inproc, noneSENTRY_NATIVE_BACKENDtonone- this will change in v9💡 Motivation and Context
💚 How did you test it?
Manually
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps