Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Python SDK doc #1066

Merged
merged 34 commits into from
Jul 1, 2019
Merged

Consolidate Python SDK doc #1066

merged 34 commits into from
Jul 1, 2019

Conversation

MimiDumpling
Copy link
Contributor

Consolidating relevant Python information into one page to help reader/user receive all the information they need in one spot.

scope.level = 'warning'
```

### Setting the Fingerprint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd land that cleanup to the 'rollups' page so it talks about sampling & fingerprints and we'd just link there

scope.set_extra("character_name", "Mighty Fighter")
```

### Unsetting Context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're telling them how to set extra context, then telling them about unsetting context, then telling them about setting more context. Probably something to be done with order of operations here. This example of unsetting context also doesnt suggest any kind of unset behavior. We should describe how to clear context within each specific context as the APIs may vary.

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prev comments by me, I think that needs to be fixed

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my POV this is good, @dcramer what do you think?

@MimiDumpling MimiDumpling merged commit 0cc6c64 into master Jul 1, 2019
untitaker added a commit that referenced this pull request Jul 12, 2019
untitaker added a commit that referenced this pull request Jul 15, 2019
* fix: Restore information about supported Python versions

As part of #1066 this
information was lost.

* fix: Add information about integrations requirements
@MimiDumpling MimiDumpling deleted the update/mimi-python-sdk branch August 22, 2019 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants