-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Python SDK doc #1066
Conversation
scope.level = 'warning' | ||
``` | ||
|
||
### Setting the Fingerprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd land that cleanup to the 'rollups' page so it talks about sampling & fingerprints and we'd just link there
scope.set_extra("character_name", "Mighty Fighter") | ||
``` | ||
|
||
### Unsetting Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're telling them how to set extra context, then telling them about unsetting context, then telling them about setting more context. Probably something to be done with order of operations here. This example of unsetting context also doesnt suggest any kind of unset behavior. We should describe how to clear context within each specific context as the APIs may vary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See prev comments by me, I think that needs to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my POV this is good, @dcramer what do you think?
As part of #1066 this information was lost.
* fix: Restore information about supported Python versions As part of #1066 this information was lost. * fix: Add information about integrations requirements
Consolidating relevant Python information into one page to help reader/user receive all the information they need in one spot.