Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore information about supported Python versions #1112

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

untitaker
Copy link
Member

As part of #1066 this
information was lost.

Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vladlutkov
Copy link

But sentry_sdk/integrations/aiohttp.py, sentry_sdk/integrations/sanic.py and sentry_sdk/integrations/tornado.py have python 3.5+ keyword async

@untitaker
Copy link
Member Author

untitaker commented Jul 13, 2019

@vladlutkov certain integrations have stricter version requirements. aiohttp supports 3.5+ so this integration only works on 3.5+. When somebody doesn't use the integration the file is not imported.

(for tornado we only support tornado versions that require 3.5+)

@untitaker
Copy link
Member Author

We are using this SDK with Python 2.7 and Django 1.8 (previously 1.6) in production for sentry.io :) This works because we never import tornado/sanic/aiohttp related integrations

@vladlutkov
Copy link

In the case of aiohttp yes it's true, but tornado supports python2.7. Can you write restrictions for integrations?

@untitaker
Copy link
Member Author

Sorry, yes, for Tornado we additionally require a minimum version of Python 3.6 because of contextvars support.

Integrations have their own requirements documented at e.g. https://docs.sentry.io/platforms/python/tornado/, I will note this here.

@vladlutkov
Copy link

Thanks

@untitaker
Copy link
Member Author

untitaker commented Jul 13, 2019

I think it's possible that the strict Python version requirements of the integration for Tornado are not necessary or easily avoidable. But it would probably require code changes.

@untitaker
Copy link
Member Author

re-requesting review just to make sure

@untitaker untitaker merged commit 8b864b7 into master Jul 15, 2019
@untitaker untitaker deleted the fix/restore-python-version-info branch July 15, 2019 09:09
@MimiDumpling
Copy link
Contributor

👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants