-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for RN SDK v5 #6230
Conversation
krystofwoldrich
commented
Feb 6, 2023
- v5.0.0 release sentry-react-native#2389
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Instead of replacing everything, what's about using v4 and v5 tabs for a while? I'm wondering if this would avoid further issues while adoption grows slowly. |
I would maybe refactor the troubleshooting The commands are the same but I've changed the notes from how to fix for new RN versions to how to fix for older versions. Also, a lot of the changes are because I change a bit of the structure, moving the Expo part, and updating what the wizard does that applies to v4 too as far as I know. Update: I've added a note and instructions for the v4. I think is clearer this way. The default will be the latest as it works with the latest 3 versions of RN and the note has instructions for SDK v4. |
The Wizard docs are missing (project creation setup on sentry.io) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some language tweaks
Co-authored-by: Liza Mock <liza.mock@sentry.io>
The migration guide and wizard page have been updated and not reviewed yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrt migration and wizard docs: few small nits, otherwise LGTM! 👍
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>