Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for RN SDK v5 #6230

Merged
merged 11 commits into from
Feb 21, 2023
Merged

Update docs for RN SDK v5 #6230

merged 11 commits into from
Feb 21, 2023

Conversation

krystofwoldrich
Copy link
Member

@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 0:39AM (UTC)

@marandaneto
Copy link
Contributor

Instead of replacing everything, what's about using v4 and v5 tabs for a while? I'm wondering if this would avoid further issues while adoption grows slowly.

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Feb 7, 2023

I would maybe refactor the troubleshooting React Native 0.69 and Higher to SDK v4 with React Native 0.69 and Higher and to the installation guide, I would add a note.

The commands are the same but I've changed the notes from how to fix for new RN versions to how to fix for older versions.

Also, a lot of the changes are because I change a bit of the structure, moving the Expo part, and updating what the wizard does that applies to v4 too as far as I know.

Update: I've added a note and instructions for the v4. I think is clearer this way. The default will be the latest as it works with the latest 3 versions of RN and the note has instructions for SDK v4.

@marandaneto
Copy link
Contributor

The Wizard docs are missing (project creation setup on sentry.io)
https://github.com/getsentry/sentry-docs/tree/master/src/wizard/react-native

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some language tweaks

src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@krystofwoldrich
Copy link
Member Author

The migration guide and wizard page have been updated and not reviewed yet.

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt migration and wizard docs: few small nits, otherwise LGTM! 👍

src/platforms/react-native/migration.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/migration.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/migration.mdx Outdated Show resolved Hide resolved
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@krystofwoldrich krystofwoldrich changed the title Update setup for RN SDK v5 Update docs for RN SDK v5 Feb 21, 2023
@krystofwoldrich krystofwoldrich merged commit 2a721a1 into master Feb 21, 2023
@krystofwoldrich krystofwoldrich deleted the react-native-v5 branch February 21, 2023 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants