v5.0.0 release #2389
Merged
v5.0.0 release #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
I've tried RN 0.70 with the latest alpha release and everything seems to be working. To my surprise activating the new TurboModules didn't break the build. I haven't find anywhere if you can mix NativeModules and TurboModules, but it would make sense that you can otherwise the transition to the new architecture would be too painful. I also tried the new Fabric renderer and errors being reported as expected. |
OutdatedAndroid Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1499093 | 358.87 ms | 363.25 ms | 4.37 ms |
| b4d768b | 316.47 ms | 334.06 ms | 17.59 ms |
| 2a133c2 | 336.00 ms | 341.78 ms | 5.78 ms |
| 70013c7 | 344.17 ms | 358.76 ms | 14.59 ms |
| b9ac2e8 | 314.22 ms | 321.52 ms | 7.30 ms |
| f669ecf | 314.46 ms | 317.86 ms | 3.40 ms |
| 17717b8 | 315.32 ms | 329.42 ms | 14.10 ms |
| 885862f | 335.92 ms | 340.49 ms | 4.57 ms |
| 5488562+dirty | 336.55 ms | 353.17 ms | 16.61 ms |
| 3dd1a5b | 337.06 ms | 344.50 ms | 7.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1499093 | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| b4d768b | 25.82 MiB | 27.86 MiB | 2.04 MiB |
| 2a133c2 | 25.82 MiB | 27.86 MiB | 2.04 MiB |
| 70013c7 | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| b9ac2e8 | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| f669ecf | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| 17717b8 | 25.82 MiB | 27.86 MiB | 2.04 MiB |
| 885862f | 25.82 MiB | 27.83 MiB | 2.01 MiB |
| 5488562+dirty | 17.73 MiB | 19.95 MiB | 2.21 MiB |
| 3dd1a5b | 25.82 MiB | 27.83 MiB | 2.01 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f669ecf | 1245.06 ms | 1274.41 ms | 29.35 ms |
| 17717b8 | 1264.14 ms | 1269.94 ms | 5.80 ms |
| 885862f | 1241.58 ms | 1252.96 ms | 11.38 ms |
| b9ac2e8 | 1229.71 ms | 1249.82 ms | 20.11 ms |
| 1499093 | 1268.78 ms | 1287.38 ms | 18.60 ms |
| 2a133c2 | 1232.78 ms | 1238.56 ms | 5.78 ms |
| 70013c7 | 1237.84 ms | 1258.46 ms | 20.62 ms |
| b4d768b | 1236.63 ms | 1257.16 ms | 20.53 ms |
| cc863df | 1256.06 ms | 1263.54 ms | 7.48 ms |
| 7bc0799+dirty | 1283.04 ms | 1290.76 ms | 7.72 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f669ecf | 1.08 MiB | 1.45 MiB | 376.28 KiB |
| 17717b8 | 1.08 MiB | 1.44 MiB | 363.17 KiB |
| 885862f | 1.08 MiB | 1.45 MiB | 376.28 KiB |
| b9ac2e8 | 1.08 MiB | 1.45 MiB | 376.28 KiB |
| 1499093 | 1.08 MiB | 1.45 MiB | 376.28 KiB |
| 2a133c2 | 1.08 MiB | 1.44 MiB | 370.49 KiB |
| 70013c7 | 1.08 MiB | 1.44 MiB | 371.41 KiB |
| b4d768b | 1.08 MiB | 1.44 MiB | 370.50 KiB |
| cc863df | 1.08 MiB | 1.44 MiB | 371.41 KiB |
| 7bc0799+dirty | 2.45 MiB | 2.83 MiB | 381.11 KiB |
Co-authored-by: GitHub <noreply@github.com>
|
Can I get a final review on this PR? It's a lot of changes and the individual changes have been reviewed already. We just need to skim it, just in case something slipped thru. |
(it's always present in 0.65+)
krystofwoldrich
approved these changes
Feb 20, 2023
kahest
reviewed
Feb 21, 2023
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| platform: ["android"] # "ios" will be added after codegen is fixed |
There was a problem hiding this comment.
what is the context of this fix? is this blocked?
There was a problem hiding this comment.
Not blocked anymore, the fix was released in RN 0.70.4. I'll add it.
kahest
reviewed
Feb 21, 2023
| @@ -1,3 +1,3 @@ | |||
| export const SDK_PACKAGE_NAME = 'npm:@sentry/react-native'; | |||
| export const SDK_NAME = 'sentry.javascript.react-native'; | |||
| export const SDK_VERSION = '4.15.0'; | |||
| export const SDK_VERSION = '5.0.0-rc.1'; | |||
There was a problem hiding this comment.
The release CI pipeline will update the version.
|
Looking forward to this for 0.69 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for v5.0.0
#skip-changelog