Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): Mention sdk 7.0.0 will capture failed HTTP requests by default #7238

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

markushi
Copy link
Member

Relevant code change: getsentry/sentry-java#2794

To be merged once sentry-java 7.0.0 is released.

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

@markushi markushi requested a review from a team as a code owner June 22, 2023 05:56
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 1:06pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 1:06pm

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few tiny tweaks.

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@shanamatthews
Copy link
Contributor

Hey @markushi - is this ready to merge?

@markushi
Copy link
Member Author

markushi commented Jul 3, 2023

@shanamatthews Nope, as SDK version 7.0 isn't out yet. 7.0 is a bigger milestone, so it might take a while until it's shipped. Let me convert it to a draft in the meantime

@markushi markushi marked this pull request as draft July 3, 2023 09:31
@philipphofmann
Copy link
Member

FYI @markushi, for Apple 8.0.0, we had a couple of PRs we only could merge once the version was released. We created a milestone to track them. If you have multiple PRs for 7.0.0 Android, maybe you can consider also creating a milestone.

@stefanosiano stefanosiano added this to the Android 7.0.0 milestone Aug 4, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@kahest kahest removed the Stale label Oct 18, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Nov 9, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 9, 2023
@kahest kahest removed the Stale label Nov 9, 2023
@romtsn romtsn marked this pull request as ready for review November 30, 2023 12:54
@romtsn romtsn merged commit bc1ce8c into master Nov 30, 2023
10 checks passed
@romtsn romtsn deleted the feat/android-okhttp-default-capture-failed-requests branch November 30, 2023 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants