Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture failed HTTP requests by default #2794

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

markushi
Copy link
Member

@markushi markushi commented Jun 22, 2023

📜 Description

💡 Motivation and Context

Fixes #2767

💚 How did you test it?

📝 Checklist

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5a214bd

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 330.94 ms 359.27 ms 28.33 ms
Size 1.72 MiB 2.28 MiB 572.21 KiB

Previous results on branch: feat/default-capture-failed-requests

Startup times

Revision Plain With Sentry Diff
41de78f 310.19 ms 370.77 ms 60.58 ms

App size

Revision Plain With Sentry Diff
41de78f 1.72 MiB 2.28 MiB 572.22 KiB

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/7.0.0@0566579). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             feat/7.0.0    #2794   +/-   ##
=============================================
  Coverage              ?   81.16%           
  Complexity            ?     4496           
=============================================
  Files                 ?      348           
  Lines                 ?    16670           
  Branches              ?     2267           
=============================================
  Hits                  ?    13530           
  Misses                ?     2193           
  Partials              ?      947           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn
Copy link
Member

romtsn commented Jun 22, 2023

Btw, I think we should do this for apollo-3 as well? @marandaneto what's your take? or is it still too early for enabling it by default?

@marandaneto
Copy link
Contributor

Btw, I think we should do this for apollo-3 as well? @marandaneto what's your take? or is it still too early for enabling it by default?

That we can't because GraphQL errors include request/response by default, it should be opt-in.

@markushi markushi merged commit 4f55fd9 into feat/7.0.0 Jul 7, 2023
@markushi markushi deleted the feat/default-capture-failed-requests branch July 7, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants