Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making DebugImagesLoader public #2957

Closed
markushi opened this issue Sep 28, 2023 · 1 comment · Fixed by #2993
Closed

Consider making DebugImagesLoader public #2957

markushi opened this issue Sep 28, 2023 · 1 comment · Fixed by #2993
Assignees
Labels

Comments

@markushi
Copy link
Member

markushi commented Sep 28, 2023

Problem Statement

For uses cases where sentry-native is initialized manually, both scope sync and the debug images loader need to manually configured.

Whilst adding the Scope observer works just fine:

options.addScopeObserver(new NdkScopeObserver(options));

Setting our default DebugImagesLoader doesn't work, as the class is package private.

options.setDebugImagesLoader(new DebugImagesLoader(options, new NativeModuleListLoader()));

Solution Brainstorm

Either expose a way to use the NDK without auto-init, or open up the DebugImagesLoader for public.

@markushi
Copy link
Member Author

markushi commented Oct 4, 2023

Let's add a comment to the class description that this requires manually initializing the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants