Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DebugImagesLoader public #2993

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

stefanosiano
Copy link
Member

📜 Description

DebugImagesLoader is now public, to allow manually init the NDK

💡 Motivation and Context

Fixes #2957

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f6e847f

@stefanosiano stefanosiano marked this pull request as ready for review October 17, 2023 10:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.58 ms 445.35 ms 66.77 ms
Size 1.72 MiB 2.29 MiB 576.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms

App size

Revision Plain With Sentry Diff
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB

Previous results on branch: feat/debug-image-loader-public

Startup times

Revision Plain With Sentry Diff
02c6e6e 324.84 ms 367.63 ms 42.79 ms

App size

Revision Plain With Sentry Diff
02c6e6e 1.72 MiB 2.29 MiB 576.41 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...main/java/io/sentry/android/core/ContextUtils.java 72.00% <100.00%> (+4.23%) ⬆️
...in/java/io/sentry/android/core/DeviceInfoUtil.java 53.53% <100.00%> (ø)
...droid/core/SystemEventsBreadcrumbsIntegration.java 85.84% <100.00%> (ø)
.../java/io/sentry/android/ndk/DebugImagesLoader.java 89.65% <ø> (ø)

📢 Thoughts on this report? Let us know!.

stefanosiano and others added 2 commits October 17, 2023 15:15
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@stefanosiano stefanosiano merged commit c296b28 into main Oct 17, 2023
21 checks passed
@stefanosiano stefanosiano deleted the feat/debug-image-loader-public branch October 17, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making DebugImagesLoader public
2 participants