Skip to content

Make DebugImagesLoader public #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Make DebugImagesLoader public #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8870ad7
DebugImagesLoader is now public, to allow manually init the NDK
stefanosiano Oct 17, 2023
30c0ec1
updated changelog
stefanosiano Oct 17, 2023
21eb03e
Update CHANGELOG.md
stefanosiano Oct 17, 2023
f6e847f
Merge branch 'main' into feat/debug-image-loader-public
stefanosiano Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Features

- Make `DebugImagesLoader` public ([#2993](https://github.com/getsentry/sentry-java/pull/2993))

### Fixes

- Set export flag on Android receivers on API 33+ ([#2990](https://github.com/getsentry/sentry-java/pull/2990))
Expand Down
6 changes: 6 additions & 0 deletions sentry-android-ndk/api/sentry-android-ndk.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ public final class io/sentry/android/ndk/BuildConfig {
public fun <init> ()V
}

public final class io/sentry/android/ndk/DebugImagesLoader : io/sentry/android/core/IDebugImagesLoader {
public fun <init> (Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/android/ndk/NativeModuleListLoader;)V
public fun clearDebugImages ()V
public fun loadDebugImages ()Ljava/util/List;
}

public final class io/sentry/android/ndk/NdkScopeObserver : io/sentry/IScopeObserver {
public fun <init> (Lio/sentry/SentryOptions;)V
public fun addBreadcrumb (Lio/sentry/Breadcrumb;)V
Expand Down
8 changes: 6 additions & 2 deletions sentry-android-ndk/src/main/java/io/sentry/android/ndk/DebugImagesLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
import org.jetbrains.annotations.Nullable;
import org.jetbrains.annotations.VisibleForTesting;

final class DebugImagesLoader implements IDebugImagesLoader {
/**
* Class used for loading the list of debug images from sentry-native. Using this class requires
* manually initializing the SDK.
*/
public final class DebugImagesLoader implements IDebugImagesLoader {

private final @NotNull SentryOptions options;

Expand All @@ -23,7 +27,7 @@ final class DebugImagesLoader implements IDebugImagesLoader {
/** we need to lock it because it could be called from different threads */
private static final @NotNull Object debugImagesLock = new Object();

DebugImagesLoader(
public DebugImagesLoader(
final @NotNull SentryAndroidOptions options,
final @NotNull NativeModuleListLoader moduleListLoader) {
this.options = Objects.requireNonNull(options, "The SentryAndroidOptions is required.");
Expand Down