-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration testing for the sentry-native new unwinder #1371
Conversation
…to close potential system dialog
it should be the current version in main which is 0.4.8, any reason why you've downgraded? |
no need of |
Jeah i had a dirty state in the submodule which i could not resolve with the current version. |
@@ -1 +1,2 @@ | |||
/build | |||
sentry-samples-android-keystore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,27 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call this into https://github.com/getsentry/sentry-java/blob/main/Makefile somehow?
sentry-samples/sentry-samples-android/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
reportHelper.label("tearDown") | ||
} | ||
|
||
// Tests are run in alphabetical order... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to be sure that they don't run in parallel
sentry-samples/sentry-samples-android/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
<meta-data android:name="io.sentry.dsn" android:value="https://1053864c67cc410aa1ffc9701bd6f93d@o447951.ingest.sentry.io/5428559" /> | ||
|
||
|
||
<meta-data android:name="io.sentry.auto-init" android:value="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's create a new sample instead of using sentry-samples-android, otherwise, the current sample is totally broken
we could call it sentry-samples-android-e2e or something like that
… a chance to present the error dialoge
the very same test should be run once getsentry/sentry-native#431 gets released (sentry-native 0.4.9) because there's also a possibility of segfaulting) |
📜 Description
Two UI tests:
.sentry-native
folderSentry Native Version:
0.4.7
version ofsentry-native
. Please check out the correct version you want to test in the sub-module.How to execute the tests on
AppCenter
:Assuming you are running on a Mac.
AppCenter
, navigate totest
and start creating a new test run.- Select `Espresso` as the test framework.
- Copy the `--app` and `--devices` parameters and finish.
AppCenter
in the command line.cd
intosentry-samples/sentry-samples-android
/Library/Android/sdk/build-tools/
sentry-samples-android-keystore
appcenter
script with following parameters./appcenter androidBuildToolsVersion keyAlias keyPass appCenterApp appCenterDevice
for example, this might look like./appcenter 29.0.3 yourKeyAlias yourKeyPass denrase/Sentry-Android-Sample e669fa3b
AppCenter
is finished on all devices...Relates to #1359
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps
AppCenter
also provides environmental variables, so we can also add info (device) to events.