fix: Rewrite the Linux module finder #431

Swatinem · 2020-11-27T18:49:18Z

It now works in memory, without requiring to mmap the libraries again,
which should make it work correctly on android when loading libraries
directly from apk or appbundle files.

I think the problem with the old memory-unsafe module finder came from
some of these mappings:

7f8cd3467000-7f8cd3475000 r--p 00000000 00:1c 7597971                    /usr/lib/libcurl.so.4.7.0
7f8cd3475000-7f8cd34da000 r-xp 0000e000 00:1c 7597971                    /usr/lib/libcurl.so.4.7.0
7f8cd34da000-7f8cd34f6000 r--p 00073000 00:1c 7597971                    /usr/lib/libcurl.so.4.7.0
7f8cd34f6000-7f8cd34f7000 ---p 0008f000 00:1c 7597971                    /usr/lib/libcurl.so.4.7.0
7f8cd34f7000-7f8cd34fa000 r--p 0008f000 00:1c 7597971                    /usr/lib/libcurl.so.4.7.0
7f8cd34fa000-7f8cd34fc000 rw-p 00092000 00:1c 7597971                    /usr/lib/libcurl.so.4.7.0

NOTE that the 4th mapping is not readable, and it has the same
offset in file as the 5th mapping. This essentially means that we have
a gap in the address space, and trying to access it will lead to
segfaults.

The new code deals primarily with file offsets, and translates them
safely to in-memory addresses, making sure that we actually can read
whatever we are trying to read.

Swatinem · 2020-11-30T11:48:16Z

Been testing a bit with android. this is what I get when extracting native libs:

73786be13000-73786be17000 r-xp 00000000 fd:05 40972                      /data/app/~~WAc02Q9FOcPyBtElEJRP4A==/io.sentry.samples.android-nRHo8bDX2EhOkbXOm78y6A==/lib/x86_64/libsentry-android.so
73786be17000-73786be18000 r--p 00003000 fd:05 40972                      /data/app/~~WAc02Q9FOcPyBtElEJRP4A==/io.sentry.samples.android-nRHo8bDX2EhOkbXOm78y6A==/lib/x86_64/libsentry-android.so
73786be48000-73786bfb1000 r-xp 00000000 fd:05 40973                      /data/app/~~WAc02Q9FOcPyBtElEJRP4A==/io.sentry.samples.android-nRHo8bDX2EhOkbXOm78y6A==/lib/x86_64/libsentry.so
73786bfb1000-73786bfb2000 ---p 00000000 00:00 0 
73786bfb2000-73786bfbf000 r--p 00169000 fd:05 40973                      /data/app/~~WAc02Q9FOcPyBtElEJRP4A==/io.sentry.samples.android-nRHo8bDX2EhOkbXOm78y6A==/lib/x86_64/libsentry.so
73786bfbf000-73786bfc0000 rw-p 00176000 fd:05 40973                      /data/app/~~WAc02Q9FOcPyBtElEJRP4A==/io.sentry.samples.android-nRHo8bDX2EhOkbXOm78y6A==/lib/x86_64/libsentry.so

And this is with non-extracted native libs:

73786bf14000-73786bf18000 r-xp 00003000 fd:05 40965                      /data/app/~~qRRavra1M6p7dw5dff3zzA==/io.sentry.samples.android-k0fTZ-qmMx5lBAjqLvP6_g==/base.apk
73786bf18000-73786bf19000 r--p 00006000 fd:05 40965                      /data/app/~~qRRavra1M6p7dw5dff3zzA==/io.sentry.samples.android-k0fTZ-qmMx5lBAjqLvP6_g==/base.apk
73786bf20000-73786bf21000 ---p 00000000 00:00 0 
73786bf21000-73786bf42000 rw-p 00000000 00:00 0                          [anon:scudo:secondary]
73786bf42000-73786bf43000 ---p 00000000 00:00 0 
73786bf43000-73786c0ac000 r-xp 00432000 fd:05 40965                      /data/app/~~qRRavra1M6p7dw5dff3zzA==/io.sentry.samples.android-k0fTZ-qmMx5lBAjqLvP6_g==/base.apk
73786c0ac000-73786c0ad000 ---p 00000000 00:00 0 
73786c0ad000-73786c0ba000 r--p 0059b000 fd:05 40965                      /data/app/~~qRRavra1M6p7dw5dff3zzA==/io.sentry.samples.android-k0fTZ-qmMx5lBAjqLvP6_g==/base.apk
73786c0ba000-73786c0bb000 rw-p 005a8000 fd:05 40965                      /data/app/~~qRRavra1M6p7dw5dff3zzA==/io.sentry.samples.android-k0fTZ-qmMx5lBAjqLvP6_g==/base.apk

so there is just a bit of executable code loaded from the middle of the apk, as expected. But we don’t have any names to work with here either.

jan-auer · 2020-12-01T13:56:46Z

src/modulefinder/sentry_modulefinder_linux.c

+    const sentry_module_t *module, uint64_t start_offset, uint64_t size)
+{
+    uint64_t addr = 0;
+    uint64_t addr_end = UINT64_MAX;


This function seems a bit more complex than it needs to be, since it tries to deal with a case that I think may not happen in practice: Reading a range across multiple contiguous mappings. If I'm not mistaken, there would only be separate mappings for whole sections or sets of sections, and we never read across sections to map the module. So I think that you can simplify this mapping to simply check each mapping individually.

Also, binary search in the mappings list could speed things up.

We only have a max number of 5 mappings, binary search is probably overkill there and maybe even worse.

src/modulefinder/sentry_modulefinder_linux.c

It now works in memory, without requiring to mmap the libraries again, which should make it work correctly on android when loading libraries directly from apk or appbundle files. I think the problem with the old memory-unsafe module finder came from some of these mappings: 7f8cd3467000-7f8cd3475000 r--p 00000000 00:1c 7597971 /usr/lib/libcurl.so.4.7.0 7f8cd3475000-7f8cd34da000 r-xp 0000e000 00:1c 7597971 /usr/lib/libcurl.so.4.7.0 7f8cd34da000-7f8cd34f6000 r--p 00073000 00:1c 7597971 /usr/lib/libcurl.so.4.7.0 7f8cd34f6000-7f8cd34f7000 ---p 0008f000 00:1c 7597971 /usr/lib/libcurl.so.4.7.0 7f8cd34f7000-7f8cd34fa000 r--p 0008f000 00:1c 7597971 /usr/lib/libcurl.so.4.7.0 7f8cd34fa000-7f8cd34fc000 rw-p 00092000 00:1c 7597971 /usr/lib/libcurl.so.4.7.0 NOTE that the 4th mapping is **not** readable, and it has the same *offset in file* as the 5th mapping. This essentially means that we have a gap in the address space, and trying to access it will lead to segfaults. The new code deals primarily with file offsets, and translates them safely to in-memory addresses, making sure that we actually can read whatever we are trying to read.

Swatinem · 2021-04-01T11:28:29Z

I updated this and added a few more cases to handle:

737b5570d000-737b5570e000 r--p 00000000 07:70 34                         /apex/com.android.runtime/lib64/bionic/libdl.so
737b5570e000-737b5570f000 r-xp 00000000 07:70 34                         /apex/com.android.runtime/lib64/bionic/libdl.so
737b5570f000-737b55710000 r--p 00000000 07:70 34                         /apex/com.android.runtime/lib64/bionic/libdl.so

Here, we have different mappings for the same file offset. For this case, we will prefer the x (executable) mapping.

For in-apk libraries, we consider the file offset as well when trying to parse the ELF and extract the code/debug-id, which seems to work.

Swatinem · 2021-04-08T10:38:47Z

Current blocker:

Figure out which start/size we want to report for the case of duplicated mappings as shown in #431 (comment)

flub · 2021-04-09T08:57:04Z

src/modulefinder/sentry_modulefinder_linux.c

 #define MIN(a, b) ((a) < (b) ? (a) : (b))

+#define ENSURE(Ptr)                                                            \
+    if (!Ptr)                                                                  \
+    goto fail


I think this is much more readable if you didn't use this macro. The combination of using a goto in a macro is a little too much for me... and you're not even saving a line

src/modulefinder/sentry_modulefinder_linux.h

this way, the start/end of modules will match the memory mapping

* feat: Add support for Qt 6 (getsentry#509) * fix: Windows SDK Compiler Warning (getsentry#511) * fix: Validate tm put into strftime (getsentry#510) * fix: Rewrite the Linux module finder (getsentry#431) It now works in memory, without requiring to mmap the libraries again, which should make it work correctly on android when loading libraries directly from apk or appbundle files. The new code will keep track of readable memory maps and will translate read requests based on the offset of those memory maps, making sure that we actually can read whatever we are trying to read. * build: Avoid building all targets (getsentry#512) It looks like cmake is broken and builds ALL the targets when the parallel option is specified first, lol * fix: Update Crashpad to 2021-04-12 and fix macOS universal build (getsentry#513) * feat: Invoke before_send hook when using Crashpad (getsentry#519) * feat: Add more Event Payload convenience methods (getsentry#517) Adds: * `sentry_value_new_exception` * `sentry_value_new_thread` * `sentry_value_new_stacktrace` * `sentry_event_add_exception` * `sentry_event_add_thread` Deprecates `sentry_event_value_add_stacktrace` * feat: Introduce `sentry_close` (getsentry#518) This replaces the former `sentry_shutdown`, which is being forwarded. * meta: Prepare Changelog for upcoming release (getsentry#522) * ref: Pass options to scope apply directly (getsentry#521) * fix: Further clean up platform libraries for static linking (getsentry#523) * fix: Better macOS availability checks (getsentry#524) This should allow building on older macOS versions as well as running on older versions by fixing the usage of __builtin_available, and adding a different clock source for older macOS versions. * release: 0.4.9 * fix: Avoid double-free on invalid DSN (getsentry#527) * meta: Use correct libunwindstack commit * fix: Allow for Unity builds (getsentry#536) * ref: Add more testcases that trigger crashes in various ways (getsentry#538) * ref(craft): Modernize Craft config (getsentry#543) * fix: Update venv and test-discovery Makefile targets (getsentry#544) * fix: Avoid recursion when using `sentry_reinstall_backend` (getsentry#548) Previously, the `inproc` and `crashpad` (on linux) backends didn’t correctly reset their signal handlers when doing `reinstall_backend` (or multiple `init` calls for that matter). This has led to an infinite loop generating crashes. The fix now correctly unregisters the inproc/crashpad signal handlers, and adds an integration test using `reinstall_backend` to make sure we do not end up in an infinite loop. Co-authored-by: Mischa Alff <mischa@mutate.se> * fix: Address -Wundef warning for SENTRY_UNITTEST defines (getsentry#549) * build: Set 32-bit option for compiling assembly as well (getsentry#550) This fixes compilation of breakpad for 32-bit systems * meta: Update break/crashpad to 2021-06-14 (getsentry#552) * fix: Shorten/Split Locked sections to avoid deadlock (getsentry#551) We have received a report that the `sentry_get_modules_list` on mac can deadlock when other code concurrently does a `dlopen` and thus invokes the `add_image` callback from a different thread. We shorten/split the locked blocks in order to avoid holding a lock in the `get_modules` function whenever the `add_image` function is being invoked possibly from other threads. * fix: Tighten Stack Usage (getsentry#553) According to some docs, JVM/JNI stacks on Android can be as small as 32K, and our own sigaltstack is not much larger with 64K. Make sure to avoid large stack allocations as much as possible. We have especially seen the literal content of `/proc/self/maps` as well as formatted addresses inside corrupted release/environment attributes, which might point to overflows that write into a previously allocated release/environment string. * meta: Update Changelog (getsentry#556) * release: 0.4.10 * reformat * fix: Make Linux modulefinder/unwinder safer (getsentry#559) This is using the `process_vm_read` call to safely poke at random memory. It also makes sure to shim the libc provided call with a direct syscall for older Android devices. * docs: Try to better explain unwind API (getsentry#564) * fix: Make Crashpad Backend respect max_breadcrumbs setting (getsentry#566) * fix: Cancel slow winhttp requests on shutdown (getsentry#570) Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> * fix: Properly close the background worker thread on timeout (getsentry#571) * fix: Possible race conditions in init/close and sessions (getsentry#545) * meta: Draft Changelog (getsentry#572) * release: 0.4.11 * feat: Make shutdown timeout customizable (getsentry#577) Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> * CMake: Link to the CURL::libcurl target when available (getsentry#579) Caters better for newer cmake versions. * meta: Update crashpad to 2021-07-14 (getsentry#580) * fix: Properly use `SENTRY_BUILD_RUNTIMESTATIC` for `sentry_fuzz_json` unit test (getsentry#583) * meta: Update break/crashpad to 2021-07-28 (getsentry#584) * release: 0.4.12 * fix: Increment CXX standard to 14 to allow crashpad build (getsentry#585) Fixes getsentry#574 * feat(STAFF-121291): Edits to be compatible with Windows * meta: Bump python dependencies (getsentry#600) The old version of pytest breaks with python 3.10 which changed a little how code object internals work. Since python 3.10 is now released it starts being used in CI. * Skip changes on ci.yml file * Change xcode version to 13.0.0 * git submodule updated Co-authored-by: Tor Arne Vestbø <torarnv@gmail.com> Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io> Co-authored-by: Luke Street <luke@street.dev> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: Sentry Bot <getsentry-bot@users.noreply.github.com> Co-authored-by: Arpad Borsos <swatinem@swatinem.de> Co-authored-by: bschatt <44769431+bschatt@users.noreply.github.com> Co-authored-by: Burak Yigit Kaya <byk@sentry.io> Co-authored-by: MikeRumplerSentry <85497711+MikeRumplerSentry@users.noreply.github.com> Co-authored-by: Mischa Alff <mischa@mutate.se> Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> Co-authored-by: andrei-mu <andrei5008@gmail.com> Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> Co-authored-by: pastdue <30942300+past-due@users.noreply.github.com> Co-authored-by: Roshan Padaki <roshanpadaki@gmail.com> Co-authored-by: mjvankampen <markjanvankampen@gmail.com> Co-authored-by: Yucel Albar <yucel@timedoctor.com> Co-authored-by: Floris Bruynooghe <flub@sentry.io>

* feat: Add support for Qt 6 (getsentry#509) * fix: Windows SDK Compiler Warning (getsentry#511) * fix: Validate tm put into strftime (getsentry#510) * fix: Rewrite the Linux module finder (getsentry#431) It now works in memory, without requiring to mmap the libraries again, which should make it work correctly on android when loading libraries directly from apk or appbundle files. The new code will keep track of readable memory maps and will translate read requests based on the offset of those memory maps, making sure that we actually can read whatever we are trying to read. * build: Avoid building all targets (getsentry#512) It looks like cmake is broken and builds ALL the targets when the parallel option is specified first, lol * fix: Update Crashpad to 2021-04-12 and fix macOS universal build (getsentry#513) * feat: Invoke before_send hook when using Crashpad (getsentry#519) * feat: Add more Event Payload convenience methods (getsentry#517) Adds: * `sentry_value_new_exception` * `sentry_value_new_thread` * `sentry_value_new_stacktrace` * `sentry_event_add_exception` * `sentry_event_add_thread` Deprecates `sentry_event_value_add_stacktrace` * feat: Introduce `sentry_close` (getsentry#518) This replaces the former `sentry_shutdown`, which is being forwarded. * meta: Prepare Changelog for upcoming release (getsentry#522) * ref: Pass options to scope apply directly (getsentry#521) * fix: Further clean up platform libraries for static linking (getsentry#523) * fix: Better macOS availability checks (getsentry#524) This should allow building on older macOS versions as well as running on older versions by fixing the usage of __builtin_available, and adding a different clock source for older macOS versions. * release: 0.4.9 * fix: Avoid double-free on invalid DSN (getsentry#527) * meta: Use correct libunwindstack commit * fix: Allow for Unity builds (getsentry#536) * ref: Add more testcases that trigger crashes in various ways (getsentry#538) * ref(craft): Modernize Craft config (getsentry#543) * fix: Update venv and test-discovery Makefile targets (getsentry#544) * fix: Avoid recursion when using `sentry_reinstall_backend` (getsentry#548) Previously, the `inproc` and `crashpad` (on linux) backends didn’t correctly reset their signal handlers when doing `reinstall_backend` (or multiple `init` calls for that matter). This has led to an infinite loop generating crashes. The fix now correctly unregisters the inproc/crashpad signal handlers, and adds an integration test using `reinstall_backend` to make sure we do not end up in an infinite loop. Co-authored-by: Mischa Alff <mischa@mutate.se> * fix: Address -Wundef warning for SENTRY_UNITTEST defines (getsentry#549) * build: Set 32-bit option for compiling assembly as well (getsentry#550) This fixes compilation of breakpad for 32-bit systems * meta: Update break/crashpad to 2021-06-14 (getsentry#552) * fix: Shorten/Split Locked sections to avoid deadlock (getsentry#551) We have received a report that the `sentry_get_modules_list` on mac can deadlock when other code concurrently does a `dlopen` and thus invokes the `add_image` callback from a different thread. We shorten/split the locked blocks in order to avoid holding a lock in the `get_modules` function whenever the `add_image` function is being invoked possibly from other threads. * fix: Tighten Stack Usage (getsentry#553) According to some docs, JVM/JNI stacks on Android can be as small as 32K, and our own sigaltstack is not much larger with 64K. Make sure to avoid large stack allocations as much as possible. We have especially seen the literal content of `/proc/self/maps` as well as formatted addresses inside corrupted release/environment attributes, which might point to overflows that write into a previously allocated release/environment string. * meta: Update Changelog (getsentry#556) * release: 0.4.10 * reformat * fix: Make Linux modulefinder/unwinder safer (getsentry#559) This is using the `process_vm_read` call to safely poke at random memory. It also makes sure to shim the libc provided call with a direct syscall for older Android devices. * docs: Try to better explain unwind API (getsentry#564) * fix: Make Crashpad Backend respect max_breadcrumbs setting (getsentry#566) * fix: Cancel slow winhttp requests on shutdown (getsentry#570) Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> * fix: Properly close the background worker thread on timeout (getsentry#571) * fix: Possible race conditions in init/close and sessions (getsentry#545) * meta: Draft Changelog (getsentry#572) * release: 0.4.11 * feat: Make shutdown timeout customizable (getsentry#577) Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> * CMake: Link to the CURL::libcurl target when available (getsentry#579) Caters better for newer cmake versions. * meta: Update crashpad to 2021-07-14 (getsentry#580) * fix: Properly use `SENTRY_BUILD_RUNTIMESTATIC` for `sentry_fuzz_json` unit test (getsentry#583) * meta: Update break/crashpad to 2021-07-28 (getsentry#584) * release: 0.4.12 * fix: Increment CXX standard to 14 to allow crashpad build (getsentry#585) Fixes getsentry#574 * Sentry-native is updated * Sentry-native and submodules are updated Co-authored-by: Tor Arne Vestbø <torarnv@gmail.com> Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io> Co-authored-by: Luke Street <luke@street.dev> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: Sentry Bot <getsentry-bot@users.noreply.github.com> Co-authored-by: Arpad Borsos <swatinem@swatinem.de> Co-authored-by: bschatt <44769431+bschatt@users.noreply.github.com> Co-authored-by: Burak Yigit Kaya <byk@sentry.io> Co-authored-by: MikeRumplerSentry <85497711+MikeRumplerSentry@users.noreply.github.com> Co-authored-by: Mischa Alff <mischa@mutate.se> Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> Co-authored-by: andrei-mu <andrei5008@gmail.com> Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> Co-authored-by: pastdue <30942300+past-due@users.noreply.github.com> Co-authored-by: Roshan Padaki <roshanpadaki@gmail.com> Co-authored-by: mjvankampen <markjanvankampen@gmail.com> Co-authored-by: Yucel Albar <yucel@timedoctor.com>

* feat: Add support for Qt 6 (getsentry#509) * fix: Windows SDK Compiler Warning (getsentry#511) * fix: Validate tm put into strftime (getsentry#510) * fix: Rewrite the Linux module finder (getsentry#431) It now works in memory, without requiring to mmap the libraries again, which should make it work correctly on android when loading libraries directly from apk or appbundle files. The new code will keep track of readable memory maps and will translate read requests based on the offset of those memory maps, making sure that we actually can read whatever we are trying to read. * build: Avoid building all targets (getsentry#512) It looks like cmake is broken and builds ALL the targets when the parallel option is specified first, lol * fix: Update Crashpad to 2021-04-12 and fix macOS universal build (getsentry#513) * feat: Invoke before_send hook when using Crashpad (getsentry#519) * feat: Add more Event Payload convenience methods (getsentry#517) Adds: * `sentry_value_new_exception` * `sentry_value_new_thread` * `sentry_value_new_stacktrace` * `sentry_event_add_exception` * `sentry_event_add_thread` Deprecates `sentry_event_value_add_stacktrace` * feat: Introduce `sentry_close` (getsentry#518) This replaces the former `sentry_shutdown`, which is being forwarded. * meta: Prepare Changelog for upcoming release (getsentry#522) * ref: Pass options to scope apply directly (getsentry#521) * fix: Further clean up platform libraries for static linking (getsentry#523) * fix: Better macOS availability checks (getsentry#524) This should allow building on older macOS versions as well as running on older versions by fixing the usage of __builtin_available, and adding a different clock source for older macOS versions. * release: 0.4.9 * fix: Avoid double-free on invalid DSN (getsentry#527) * meta: Use correct libunwindstack commit * fix: Allow for Unity builds (getsentry#536) * ref: Add more testcases that trigger crashes in various ways (getsentry#538) * ref(craft): Modernize Craft config (getsentry#543) * fix: Update venv and test-discovery Makefile targets (getsentry#544) * fix: Avoid recursion when using `sentry_reinstall_backend` (getsentry#548) Previously, the `inproc` and `crashpad` (on linux) backends didn’t correctly reset their signal handlers when doing `reinstall_backend` (or multiple `init` calls for that matter). This has led to an infinite loop generating crashes. The fix now correctly unregisters the inproc/crashpad signal handlers, and adds an integration test using `reinstall_backend` to make sure we do not end up in an infinite loop. Co-authored-by: Mischa Alff <mischa@mutate.se> * fix: Address -Wundef warning for SENTRY_UNITTEST defines (getsentry#549) * build: Set 32-bit option for compiling assembly as well (getsentry#550) This fixes compilation of breakpad for 32-bit systems * meta: Update break/crashpad to 2021-06-14 (getsentry#552) * fix: Shorten/Split Locked sections to avoid deadlock (getsentry#551) We have received a report that the `sentry_get_modules_list` on mac can deadlock when other code concurrently does a `dlopen` and thus invokes the `add_image` callback from a different thread. We shorten/split the locked blocks in order to avoid holding a lock in the `get_modules` function whenever the `add_image` function is being invoked possibly from other threads. * fix: Tighten Stack Usage (getsentry#553) According to some docs, JVM/JNI stacks on Android can be as small as 32K, and our own sigaltstack is not much larger with 64K. Make sure to avoid large stack allocations as much as possible. We have especially seen the literal content of `/proc/self/maps` as well as formatted addresses inside corrupted release/environment attributes, which might point to overflows that write into a previously allocated release/environment string. * meta: Update Changelog (getsentry#556) * release: 0.4.10 * reformat * fix: Make Linux modulefinder/unwinder safer (getsentry#559) This is using the `process_vm_read` call to safely poke at random memory. It also makes sure to shim the libc provided call with a direct syscall for older Android devices. * docs: Try to better explain unwind API (getsentry#564) * fix: Make Crashpad Backend respect max_breadcrumbs setting (getsentry#566) * fix: Cancel slow winhttp requests on shutdown (getsentry#570) Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> * fix: Properly close the background worker thread on timeout (getsentry#571) * fix: Possible race conditions in init/close and sessions (getsentry#545) * meta: Draft Changelog (getsentry#572) * release: 0.4.11 * feat: Make shutdown timeout customizable (getsentry#577) Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> * CMake: Link to the CURL::libcurl target when available (getsentry#579) Caters better for newer cmake versions. * meta: Update crashpad to 2021-07-14 (getsentry#580) * fix: Properly use `SENTRY_BUILD_RUNTIMESTATIC` for `sentry_fuzz_json` unit test (getsentry#583) * meta: Update break/crashpad to 2021-07-28 (getsentry#584) * release: 0.4.12 * fix: Increment CXX standard to 14 to allow crashpad build (getsentry#585) Fixes getsentry#574 * feat(STAFF-121291): Edits to be compatible with Windows * meta: Bump python dependencies (getsentry#600) The old version of pytest breaks with python 3.10 which changed a little how code object internals work. Since python 3.10 is now released it starts being used in CI. * Skip changes on ci.yml file * Change xcode version to 13.0.0 * git submodule updated * Crashpad submodule is updated Co-authored-by: Tor Arne Vestbø <torarnv@gmail.com> Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io> Co-authored-by: Luke Street <luke@street.dev> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: Sentry Bot <getsentry-bot@users.noreply.github.com> Co-authored-by: Arpad Borsos <swatinem@swatinem.de> Co-authored-by: bschatt <44769431+bschatt@users.noreply.github.com> Co-authored-by: Burak Yigit Kaya <byk@sentry.io> Co-authored-by: MikeRumplerSentry <85497711+MikeRumplerSentry@users.noreply.github.com> Co-authored-by: Mischa Alff <mischa@mutate.se> Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> Co-authored-by: andrei-mu <andrei5008@gmail.com> Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> Co-authored-by: pastdue <30942300+past-due@users.noreply.github.com> Co-authored-by: Roshan Padaki <roshanpadaki@gmail.com> Co-authored-by: mjvankampen <markjanvankampen@gmail.com> Co-authored-by: Yucel Albar <yucel@timedoctor.com> Co-authored-by: Floris Bruynooghe <flub@sentry.io>

) * feat: Add support for Qt 6 (getsentry#509) * fix: Windows SDK Compiler Warning (getsentry#511) * fix: Validate tm put into strftime (getsentry#510) * fix: Rewrite the Linux module finder (getsentry#431) It now works in memory, without requiring to mmap the libraries again, which should make it work correctly on android when loading libraries directly from apk or appbundle files. The new code will keep track of readable memory maps and will translate read requests based on the offset of those memory maps, making sure that we actually can read whatever we are trying to read. * build: Avoid building all targets (getsentry#512) It looks like cmake is broken and builds ALL the targets when the parallel option is specified first, lol * fix: Update Crashpad to 2021-04-12 and fix macOS universal build (getsentry#513) * feat: Invoke before_send hook when using Crashpad (getsentry#519) * feat: Add more Event Payload convenience methods (getsentry#517) Adds: * `sentry_value_new_exception` * `sentry_value_new_thread` * `sentry_value_new_stacktrace` * `sentry_event_add_exception` * `sentry_event_add_thread` Deprecates `sentry_event_value_add_stacktrace` * feat: Introduce `sentry_close` (getsentry#518) This replaces the former `sentry_shutdown`, which is being forwarded. * meta: Prepare Changelog for upcoming release (getsentry#522) * ref: Pass options to scope apply directly (getsentry#521) * fix: Further clean up platform libraries for static linking (getsentry#523) * fix: Better macOS availability checks (getsentry#524) This should allow building on older macOS versions as well as running on older versions by fixing the usage of __builtin_available, and adding a different clock source for older macOS versions. * release: 0.4.9 * fix: Avoid double-free on invalid DSN (getsentry#527) * meta: Use correct libunwindstack commit * fix: Allow for Unity builds (getsentry#536) * ref: Add more testcases that trigger crashes in various ways (getsentry#538) * ref(craft): Modernize Craft config (getsentry#543) * fix: Update venv and test-discovery Makefile targets (getsentry#544) * fix: Avoid recursion when using `sentry_reinstall_backend` (getsentry#548) Previously, the `inproc` and `crashpad` (on linux) backends didn’t correctly reset their signal handlers when doing `reinstall_backend` (or multiple `init` calls for that matter). This has led to an infinite loop generating crashes. The fix now correctly unregisters the inproc/crashpad signal handlers, and adds an integration test using `reinstall_backend` to make sure we do not end up in an infinite loop. Co-authored-by: Mischa Alff <mischa@mutate.se> * fix: Address -Wundef warning for SENTRY_UNITTEST defines (getsentry#549) * build: Set 32-bit option for compiling assembly as well (getsentry#550) This fixes compilation of breakpad for 32-bit systems * meta: Update break/crashpad to 2021-06-14 (getsentry#552) * fix: Shorten/Split Locked sections to avoid deadlock (getsentry#551) We have received a report that the `sentry_get_modules_list` on mac can deadlock when other code concurrently does a `dlopen` and thus invokes the `add_image` callback from a different thread. We shorten/split the locked blocks in order to avoid holding a lock in the `get_modules` function whenever the `add_image` function is being invoked possibly from other threads. * fix: Tighten Stack Usage (getsentry#553) According to some docs, JVM/JNI stacks on Android can be as small as 32K, and our own sigaltstack is not much larger with 64K. Make sure to avoid large stack allocations as much as possible. We have especially seen the literal content of `/proc/self/maps` as well as formatted addresses inside corrupted release/environment attributes, which might point to overflows that write into a previously allocated release/environment string. * meta: Update Changelog (getsentry#556) * release: 0.4.10 * reformat * fix: Make Linux modulefinder/unwinder safer (getsentry#559) This is using the `process_vm_read` call to safely poke at random memory. It also makes sure to shim the libc provided call with a direct syscall for older Android devices. * docs: Try to better explain unwind API (getsentry#564) * fix: Make Crashpad Backend respect max_breadcrumbs setting (getsentry#566) * fix: Cancel slow winhttp requests on shutdown (getsentry#570) Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> * fix: Properly close the background worker thread on timeout (getsentry#571) * fix: Possible race conditions in init/close and sessions (getsentry#545) * meta: Draft Changelog (getsentry#572) * release: 0.4.11 * feat: Make shutdown timeout customizable (getsentry#577) Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> * CMake: Link to the CURL::libcurl target when available (getsentry#579) Caters better for newer cmake versions. * meta: Update crashpad to 2021-07-14 (getsentry#580) * fix: Properly use `SENTRY_BUILD_RUNTIMESTATIC` for `sentry_fuzz_json` unit test (getsentry#583) * meta: Update break/crashpad to 2021-07-28 (getsentry#584) * release: 0.4.12 * fix: Increment CXX standard to 14 to allow crashpad build (getsentry#585) Fixes getsentry#574 * meta: Bump python dependencies (getsentry#600) The old version of pytest breaks with python 3.10 which changed a little how code object internals work. Since python 3.10 is now released it starts being used in CI. * fix: Ensure that a valid DSN has a public_key (getsentry#598) * feat: AIX support (getsentry#593) * CMake: Check whether libcurl was already found (getsentry#602) Currently when there is any other project that brings libcurl as a dependency, the build fails with “Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR)“, even though libcurl has already added as CURL::libcurl library. This patch adds a check for CURL_FOUND, to indicate that the library was already found, if set by another project. It also skips the additional find_package() step so it does not fail. Signed-off-by: Ladislav Macoun <ladislavmacoun@gmail.com> * CMake: fix `SENTRY_BACKEND` defined in outer scope (getsentry#603) * CMake: add ability to set solution folder name (getsentry#604) * [pull] master from getsentry:master (#14) * ci(codechecker): Workaround for code checker not building due to node issues (getsentry#615) * meta: Update breakpad/crashpad to 2021-12-03 (getsentry#614) * feat(tracing): Add config options (getsentry#613) * fix: Correct changelog entry (getsentry#622) * meta: Bump breakpad (getsentry#621) * feat: Add internal UUID types (getsentry#616) This adds in support for internal UUIDs needed by tracing, such as the trace ID and the span ID. The major difference between this and the "standard" UUID is that the hyphens are stripped during serialization. sentry appears to not consider the hyphenated representations of these UUIDs to be valid for certain fields in an event. * meta: Update changelog (getsentry#625) * release: 0.4.13 * feat(tracing): Groundwork to add tracing context to all events (getsentry#617) This adds the appropriate stubs and fields to start storing spans on the (universal) scope. No actual logic has been added to actually support setting spans on the scope itself. The focus of this is to begin including tracing info in the context on all events if there is a transaction set on the scope. It does this fairly naively right now as the tooling to merge `sentry_value_t`s are basically nonexistent. * ci: Make integration tests capable of reading the non-backwards compatible version number for Big Sur (getsentry#627) * feat(tracing): Basic transaction context creation (getsentry#619) This adds in the ability to create and manipulate transaction contexts as defined in https://develop.sentry.dev/sdk/performance/#new-span-and-transaction-classes, under Transaction Interface. Instead of defining several transaction constructor functions with varying names (since overloading doesn't exist), the decision has been made to have the user construct an "inactive" transaction which should be fed into the SDK's implementation of `start_transaction`. This follows an existing pattern in the SDK where exceptions, threads, messages, etc can be constructed but they must be explicitly added to an event to be sent to sentry. * feat(tracing): Support basic sampling of transactions (getsentry#620) If an event is a transaction, event flushing should determine discard or forward the transaction to sentry based on the sample rate as configured in sentry options. Follows the sampling rules as defined in https://develop.sentry.dev/sdk/performance/#sampling-context. This does not take into consideration parent sampling as that property is currently unimplemented on the transaction context. * feat(tracing): Introduce a helper that identifies events that are transactions (getsentry#628) * feat(tracing): Restrict `sentry_capture_event` so it only sends non-transaction events (getsentry#629) Prevent the public API from being used to send transaction events as another transaction-specific function is meant to be used to accomplish this. * fix: Avoid deadlocks with uninitialized options (getsentry#639) The `SENTRY_WITH_OPTIONS_MUT` was a footgun since it never unlocked when the options were NULL (uninitialized). This removes the macro and replaces its uses with explicit lock/unlock calls. * feat(tracing): Add in basic Envelope support for Transactions (getsentry#630) * feat(tracing): Allow manual creation and sending of spanless Transactions (getsentry#631) * feat(tracing): Defer some transaction validation and allow creation of internal spans (getsentry#633) Co-authored-by: relaxolotl <5597345+relaxolotl@users.noreply.github.com> Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Arpad Borsos <swatinem@swatinem.de> Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io> Co-authored-by: Tor Arne Vestbø <torarnv@gmail.com> Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io> Co-authored-by: Luke Street <luke@street.dev> Co-authored-by: getsentry-bot <bot@getsentry.com> Co-authored-by: Sentry Bot <getsentry-bot@users.noreply.github.com> Co-authored-by: Arpad Borsos <swatinem@swatinem.de> Co-authored-by: bschatt <44769431+bschatt@users.noreply.github.com> Co-authored-by: Burak Yigit Kaya <byk@sentry.io> Co-authored-by: MikeRumplerSentry <85497711+MikeRumplerSentry@users.noreply.github.com> Co-authored-by: Mischa Alff <mischa@mutate.se> Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Gerhard Herbert <gerhard.herbert@avira.com> Co-authored-by: andrei-mu <andrei5008@gmail.com> Co-authored-by: Andrei Muraru <andrei.muraru@avira.com> Co-authored-by: pastdue <30942300+past-due@users.noreply.github.com> Co-authored-by: Roshan Padaki <roshanpadaki@gmail.com> Co-authored-by: mjvankampen <markjanvankampen@gmail.com> Co-authored-by: Floris Bruynooghe <flub@sentry.io> Co-authored-by: Calvin Buckley <calvin@cmpct.info> Co-authored-by: Ladislav <ladislavmacoun@gmail.com> Co-authored-by: Mikhail Paulyshka <me@mixaill.tk> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: relaxolotl <5597345+relaxolotl@users.noreply.github.com> Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>

Swatinem requested a review from a team November 27, 2020 18:49

Swatinem marked this pull request as draft November 30, 2020 12:44

jan-auer reviewed Dec 1, 2020

View reviewed changes

marandaneto mentioned this pull request Jan 7, 2021

Android Proguard stacktraces are not readable even after uploading the symbol files getsentry/sentry-dart#261

Closed

11 tasks

Swatinem and others added 2 commits April 1, 2021 11:18

correctly skip duplicate entries and process relative mappings

323c4f7

Swatinem force-pushed the fix/better-modulefinder branch from 45183db to 323c4f7 Compare April 1, 2021 11:22

fix compile and valgrind errors

737dc9b

flub self-requested a review April 1, 2021 14:01

improve valgrind suppressions

af46a3d

Swatinem marked this pull request as ready for review April 2, 2021 09:32

review

e33847d

flub removed their request for review April 8, 2021 08:48

Swatinem requested review from a team and jan-auer April 8, 2021 09:22

flub approved these changes Apr 9, 2021

View reviewed changes

Swatinem added 4 commits April 9, 2021 11:53

Merge branch 'master' into fix/better-modulefinder

94e3e80

review

74e4400

remove dedupe code

5811aef

this way, the start/end of modules will match the memory mapping

fix modulefinder test

81a590c

Swatinem merged commit 03ebec7 into master Apr 9, 2021

Swatinem deleted the fix/better-modulefinder branch April 9, 2021 12:49

This was referenced Apr 14, 2021

Integration testing for the sentry-native new unwinder getsentry/sentry-java#1371

Closed

Feature Request: Support so unextracted .so files in APKs getsentry/sentry-java#1280

Closed

Swatinem mentioned this pull request Apr 16, 2021

Android + Sentry Native - Section Crashed is not in Loaded Images #483

Closed

3 tasks

JodiTheTigger mentioned this pull request Dec 22, 2021

Linux Module finder is broken, also crashes when creating stack trace #640

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Rewrite the Linux module finder #431

fix: Rewrite the Linux module finder #431

Swatinem commented Nov 27, 2020 •

edited by jan-auer

Loading

Swatinem commented Nov 30, 2020

jan-auer Dec 1, 2020

Swatinem Apr 2, 2021

Swatinem commented Apr 1, 2021

Swatinem commented Apr 8, 2021

flub Apr 9, 2021

fix: Rewrite the Linux module finder #431

fix: Rewrite the Linux module finder #431

Conversation

Swatinem commented Nov 27, 2020 • edited by jan-auer Loading

Swatinem commented Nov 30, 2020

jan-auer Dec 1, 2020

Choose a reason for hiding this comment

Swatinem Apr 2, 2021

Choose a reason for hiding this comment

Swatinem commented Apr 1, 2021

Swatinem commented Apr 8, 2021

flub Apr 9, 2021

Choose a reason for hiding this comment

Swatinem commented Nov 27, 2020 •

edited by jan-auer

Loading