-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Add session replay envelope and events #3214
[SR] Add session replay envelope and events #3214
Conversation
…replay-map-object-reader
…replay-map-object-reader
…replay-map-object-reader
@markushi @stefanosiano I'll wait with merging #3215 otherwise it'll be hell to review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments, and stopped at some point adding final and @NotNull
annotations. But apart from that, LGTM!
thank you! I will revise that myself and add where necessary |
…ject-reader [SR] Introduce MapObjectReader
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed only the Session Replay related changes (all the serialization change could have been a different PR), and it looks good.
I wrote just a few comments for discussion.
#skip-changelog
📜 Description
You can read up more about the new envelope spec here getsentry/rfcs#129
It has a good chunk of work that you've done during the hackweek, but with several enhancements:
MapObjectReader
and extract anObjectReader
interface fromJsonObjectReader
but I made a separate PR for this (this one will be failing until the other one is merged)💡 Motivation and Context
Closes #3213
💚 How did you test it?
With tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
Glue recording and envelopes together