-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Introduce MapObjectReader #3215
Merged
romtsn
merged 7 commits into
rz/feat/session-replay-envelopes
from
rz/feat/session-replay-map-object-reader
Feb 28, 2024
Merged
[SR] Introduce MapObjectReader #3215
romtsn
merged 7 commits into
rz/feat/session-replay-envelopes
from
rz/feat/session-replay-map-object-reader
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
February 20, 2024 23:41
…replay-map-object-reader
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e79b82 | 354.06 ms | 437.15 ms | 83.09 ms |
8bd0d19 | 370.40 ms | 456.58 ms | 86.18 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e79b82 | 1.70 MiB | 2.28 MiB | 591.07 KiB |
8bd0d19 | 1.70 MiB | 2.28 MiB | 591.11 KiB |
markushi
reviewed
Feb 21, 2024
@@ -86,8 +86,7 @@ public static Breadcrumb fromMap( | |||
switch (entry.getKey()) { | |||
case JsonKeys.TIMESTAMP: | |||
if (value instanceof String) { | |||
Date deserializedDate = | |||
JsonObjectReader.dateOrNull((String) value, options.getLogger()); | |||
Date deserializedDate = ObjectReader.dateOrNull((String) value, options.getLogger()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Date deserializedDate = ObjectReader.dateOrNull((String) value, options.getLogger()); | |
final Date deserializedDate = ObjectReader.dateOrNull((String) value, options.getLogger()); |
markushi
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice!
…replay-map-object-reader
…replay-map-object-reader
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Add new sentry-android-replay module## 📜 Description
ObjectReader
fromJsonObjecteReader
and introduce a newMapObjectReader
analogous to what @markushi has done for the hybrid SDKs in Add API to retrieve Android scope data #2814There are still some rough edges I believe, but it works for the current replay usecase, and I think it should be fine. I'll add some tests but won't cover everything (will fix stuff along-the-way if I find something).
💡 Motivation and Context
Next Steps
Add some tests for the MapObjectReader