Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay] Expose rrweb recordCrossOriginIframes under _experiment #14809

Closed
bruno-garcia opened this issue Dec 19, 2024 · 0 comments · Fixed by #14916
Closed

[Replay] Expose rrweb recordCrossOriginIframes under _experiment #14809

bruno-garcia opened this issue Dec 19, 2024 · 0 comments · Fixed by #14916
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@bruno-garcia
Copy link
Member

Description

See: #11858

Came up a few times and it's a feature supported by rrweb.
This can have some challenges that will put more pressure in supporting this feature, since we had issues early on when testing it.

But adding this under _experiment so folks can try it out and unblock themselves while communicating this isn't a GA functionality is a good next step

@bruno-garcia bruno-garcia added the Package: replay Issues related to the Sentry Replay SDK label Dec 19, 2024
dgavranic added a commit to dgavranic/sentry-javascript that referenced this issue Jan 7, 2025
getsentry#14809)

Expose the `recordCrossOriginIframes` option under `_experiments`.
This option records cross-origin iframes for session replay.
dgavranic added a commit to dgavranic/sentry-javascript that referenced this issue Jan 7, 2025
getsentry#14809)

Expose the `recordCrossOriginIframes` option under `_experiments`.
This option records cross-origin iframes for session replay.
billyvg added a commit that referenced this issue Feb 19, 2025
#14916)

Closes #14809.

I have tested this with my project and it sort of works. While it's not
perfect (sometimes produces an unplayable replay), it might unblock
other users looking to experiment with this feature.

Verify:
- [ ] If you've added code that should be tested, please add tests.
- [x] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).

This just exposes the API under experiments, as such I don't think it
requires tests.

---------

Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant