feat(replay): Expose rrweb recordCrossOriginIframes under _experiments #14916
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getsentry#14809) Expose the `recordCrossOriginIframes` option under `_experiments`. This option records cross-origin iframes for session replay.
billyvg
reviewed
Feb 14, 2025
Comment on lines
155
to
159
| // experimental support for recording iframes from different origins | ||
| if (_experiments.recordCrossOriginIframes) { | ||
| this._recordingOptions.recordCrossOriginIframes = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add this directly to this._recordingOptions?
this._recordingOptions = {
...
recordCrossOriginIframes: Boolean(_experiments.recordCrossOriginIframes),
};
billyvg
reviewed
Feb 14, 2025
billyvg
reviewed
Feb 14, 2025
billyvg
approved these changes
Feb 14, 2025
chargome
approved these changes
Feb 17, 2025
| @@ -229,6 +229,7 @@ export interface ReplayPluginOptions extends ReplayNetworkOptions { | |||
| captureExceptions: boolean; | |||
| traceInternals: boolean; | |||
| continuousCheckout: number; | |||
| recordCrossOriginIframes: boolean; | |||
There was a problem hiding this comment.
We could leave a note here for security concerns and link to https://github.com/rrweb-io/rrweb/blob/master/docs/recipes/cross-origin-iframes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14809.
I have tested this with my project and it sort of works. While it's not perfect (sometimes produces an unplayable replay), it might unblock other users looking to experiment with this feature.
Verify:
yarn lint) & (yarn test).This just exposes the API under experiments, as such I don't think it requires tests.