Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Merge @sentry-internal/tracing into @sentry/core #9885

Closed
7 tasks done
Tracked by #9508
mydea opened this issue Dec 18, 2023 · 0 comments · Fixed by #11484
Closed
7 tasks done
Tracked by #9508

[v8] Merge @sentry-internal/tracing into @sentry/core #9885

mydea opened this issue Dec 18, 2023 · 0 comments · Fixed by #11484
Assignees
@AbhiPrasad
Milestone
8.0.0

Comments

@mydea
Copy link
Member

mydea commented Dec 18, 2023 •
edited by AbhiPrasad
Loading

In v8, let's merge tracing-internals into core, and stop publishing @sentry-internal/tracing.

Tasks
Beta Give feedback
  1. [v8] Remove @sentry/tracing package #8796
    Meta: Breaking
    AbhiPrasad
  2. feat(v8): Remove @sentry/tracing #10625
    ci-skip-cache
    AbhiPrasad
  3. feat(v8): Remove autoDiscoverNodePerformanceMonitoringIntegrations #10917
    AbhiPrasad
  4. feat(v8/core): Move addTracingHeadersToFetchRequest and instrumentFetchRequest to core #10918
    AbhiPrasad
  5. feat(v8/tracing): Delete BrowserTracing class #10919
    AbhiPrasad
  6. feat(tracing): Remove instrumentRoutingWithDefaults #11240
    AbhiPrasad
  7. ref(browser): Move browserTracing into browser pkg #11484
    AbhiPrasad
@mydea mydea added this to the 8.0.0 milestone Dec 18, 2023
@mydea mydea mentioned this issue Dec 18, 2023
Closed
@AbhiPrasad AbhiPrasad self-assigned this Feb 22, 2024
@AbhiPrasad AbhiPrasad mentioned this issue Feb 23, 2024
Closed
This was referenced Mar 5, 2024
Closed
Merged
Merged
AbhiPrasad added a commit that referenced this issue Mar 5, 2024
@AbhiPrasad
feat(v8/tracing): Delete BrowserTracing class (#10919)
3da0839 
With this PR and
#10918 merged, we can
move all of the browser tracing related code into `@sentry/browser`.
That will allow us to delete `@sentry-internal/tracing` and stop
publishing it.

ref #9885
AbhiPrasad added a commit that referenced this issue Mar 5, 2024
@AbhiPrasad
feat(v8/core): Move addTracingHeadersToFetchRequest and instrumentFet…
b5f820b 
…chRequest to core (#10918)

With this change we should be ready to move browser tracing into the
browser package

ref: #9885
This was referenced Mar 18, 2024
Open
Merged
AbhiPrasad added a commit that referenced this issue Mar 22, 2024
@AbhiPrasad
feat(tracing): Remove instrumentRoutingWithDefaults (#11240)
b846671 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of #9885 since
it makes it easier to port over browsertracing into browser package.
c298lee pushed a commit that referenced this issue Mar 22, 2024
@AbhiPrasad @c298lee
feat(tracing): Remove instrumentRoutingWithDefaults (#11240)
5dd7202 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of #9885 since
it makes it easier to port over browsertracing into browser package.
c298lee pushed a commit that referenced this issue Mar 23, 2024
@AbhiPrasad @c298lee
feat(tracing): Remove instrumentRoutingWithDefaults (#11240)
cb45cbc 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of #9885 since
it makes it easier to port over browsertracing into browser package.
@AbhiPrasad AbhiPrasad mentioned this issue Apr 2, 2024
Merged
AbhiPrasad added a commit that referenced this issue Apr 5, 2024
@AbhiPrasad
feat: Add @sentry-internal/browser-utils (#11381)
3f9cd43 
This PR creates a `browser-utils` package that contains browser specific
utils that can be shared between the browser, replay, and feedback
packages.

Eventually we will move `browserTracingIntegration` outside of this
package, but the instrumentation handlers will remain here. We will also
move the browser related utils in `@sentry/utils` to this package.

Given this removes `@sentry-internal/tracing` entirely, it is a part of
#9885

ref #9832
@AbhiPrasad AbhiPrasad mentioned this issue Apr 8, 2024
Merged
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(tracing): Remove instrumentRoutingWithDefaults (getsentry#11240)
a4b66e1 
This functionality is no longer being used, so we can remove it and it's
tests.

Part of getsentry#9885 since
it makes it easier to port over browsertracing into browser package.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat: Add @sentry-internal/browser-utils (getsentry#11381)
6bfd4ed 
This PR creates a `browser-utils` package that contains browser specific
utils that can be shared between the browser, replay, and feedback
packages.

Eventually we will move `browserTracingIntegration` outside of this
package, but the instrumentation handlers will remain here. We will also
move the browser related utils in `@sentry/utils` to this package.

Given this removes `@sentry-internal/tracing` entirely, it is a part of
getsentry#9885

ref getsentry#9832
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
ref(browser): Move browserTracing into browser pkg (getsentry#11484)
597099b 
This PR moves `browserTracingIntegration` into the browser package,
leaving `browser-utils` only existing purely for utils/instrumentation
(and our vendored web vitals implementation).

resolves getsentry#9885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

ref(browser): Move browserTracing into browser pkg getsentry/sentry-javascript
2 participants
@mydea @AbhiPrasad