Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v8): Remove autoDiscoverNodePerformanceMonitoringIntegrations #10917

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 5, 2024

ref #9885

- Remove autoDiscoverNodePerformanceMonitoringIntegrations
- Remove lazyLoadedNodePerformanceMonitoringIntegrations
@AbhiPrasad AbhiPrasad requested a review from a team March 5, 2024 00:20
@AbhiPrasad AbhiPrasad self-assigned this Mar 5, 2024
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and lforst and removed request for a team March 5, 2024 00:20
@mydea
Copy link
Member

mydea commented Mar 5, 2024

Hmm is it OK to delete the integrations yet? Don't we need them in metaframeworks still, I wonder (e.g. http instrumentation etc. in next/remix/etc)?

@AbhiPrasad
Copy link
Member Author

All of these integrations should be safe to delete, everything else lives in node/core as appropriate. Only exception is express, as highlighted in the issue.

@mydea
Copy link
Member

mydea commented Mar 6, 2024

OK, just to clarify: So e.g. next/remix/astro do not use/depend on the DB integrations? Does that not mean you cannot e.g. instrument your mysql usage in the server side of next/remix/... anymore then?

Maybe this is fine - I've also looked into deleting this, which would help us quite a bit, but held off so far because I thought we'd still need this for the time being 😅

@AbhiPrasad
Copy link
Member Author

So e.g. next/remix/astro do not use/depend on the DB integrations

Ahhh I see what you mean. All of these are optional, but given we haven't converted the packages to use otel this does mean it will break for some.

I'll draft for now, we can come back to this!

@AbhiPrasad AbhiPrasad marked this pull request as draft March 6, 2024 18:10
@AbhiPrasad AbhiPrasad closed this Mar 15, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-remove-autoDiscoverNodePerformanceMonitoringIntegrations branch June 24, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants