fix(angular-ivy): Add exports field to package.json
#10569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
andreialecu
reviewed
Feb 8, 2024
Co-authored-by: Andrei Alecu <aandrei03@gmail.com>
mydea
approved these changes
Feb 8, 2024
Lms24
added a commit
that referenced
this pull request
Feb 12, 2024
Add an `exports` field to the `package.json` for `@sentry/angular-ivy`. While it seems like regular Angular apps didn't need it, tools like `vitest` expect the field as soon as `type: "module"` is specified. --- Co-authored-by: Andrei Alecu <aandrei03@gmail.com>
Lms24
added a commit
that referenced
this pull request
Feb 12, 2024
Add an `exports` field to the `package.json` for `@sentry/angular-ivy`. While it seems like regular Angular apps didn't need it, tools like `vitest` expect the field as soon as `type: "module"` is specified. --- Co-authored-by: Andrei Alecu <aandrei03@gmail.com>
This was referenced Feb 12, 2024
This was referenced Mar 12, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
exportsfield to thepackage.jsonfor@sentry/angular-ivy. While it seems like regular Angular apps didn't need it, tools likevitestexpect the field as soon astype: "module"is specified.IMO this is just a fix for v7 as we'll bump the APF from Angular 12 to at least Angular 14 in v8. So once this is in, I'll also backport the fix to
v7.In addition to the repro provided in #10511, I also tested with Angular 12 and Angular 17 test apps. Seemed to work so far.
closes #10511