Skip to content

feat: Export semantic attribute keys from SDK packages #10637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

feat: Export semantic attribute keys from SDK packages #10637

merged 1 commit into from
Feb 13, 2024

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 13, 2024 •
edited
Loading

Given users should make use of attributes when performing custom instrumentation, this PR adds exports for our semantic attributes keys from the SDK packages so that users don't have to install @sentry/core explicitly.

@Lms24 Lms24 changed the title feat: Export semantic attribute keys in SDK packages feat: Export semantic attribute keys from SDK packages Feb 13, 2024
@Lms24 Lms24 requested review from AbhiPrasad and mydea February 13, 2024 10:56
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.79 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.66 KB (-0.22% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.23 KB (-0.44% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.13 KB (-0.31% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser - Webpack (gzipped) 22.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.1 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.62 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.6 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.7 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.89 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.51 KB (-0.05% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.03 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.87 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.41 KB (-0.21% 🔽)
@sentry/react - Webpack (gzipped) 22.46 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.09 KB (-0.26% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.36 KB (-0.16% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (0%)

@Lms24 Lms24 merged commit ef37a80 into develop Feb 13, 2024
@Lms24 Lms24 deleted the lms/feat-export-semantic-attribute-keys branch February 13, 2024 12:59
Lms24 added a commit that referenced this pull request Feb 13, 2024
@Lms24
feat: Export semantic attribute keys from SDK packages (#10637)
dd31fdb 
Add exports for our semantic attributes keys
from the SDK packages so that users don't have to install `@sentry/core`
explicitly.
@Lms24 Lms24 mentioned this pull request Feb 13, 2024
Merged
mydea pushed a commit that referenced this pull request Feb 13, 2024
@Lms24 @mydea
feat: Export semantic attribute keys from SDK packages (#10637)
8ba1d77 
Add exports for our semantic attributes keys
from the SDK packages so that users don't have to install `@sentry/core`
explicitly.
This was referenced Feb 14, 2024
Merged
Closed
Merged
This was referenced Mar 12, 2024
Merged
Closed
@Lms24 Lms24 mentioned this pull request Mar 20, 2024
Merged
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
Merged
@Lms24 Lms24 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24 @mydea