Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(svelte): Avoid running vitest in watch mode #10655

Merged
merged 1 commit into from
Feb 14, 2024
Merged

test(svelte): Avoid running vitest in watch mode #10655

merged 1 commit into from
Feb 14, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 14, 2024 •
edited
Loading

To not run in watch mode we need to specifically run vitest run instead of vitest (missed this when reviewing #10350).

  • yarn test will run the test suites once
  • yarn test:watch will continue to run the tests in watch mode

Also unstaled yarn.lock which we also seem to have missed in #10350

@Lms24 Lms24 requested review from mydea and lforst February 14, 2024 14:16
@Lms24 Lms24 merged commit fa8b205 into develop Feb 14, 2024
97 checks passed
@Lms24 Lms24 deleted the lms/test-svelte-vitest-watch branch February 14, 2024 14:43
@Lms24 Lms24 mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lms24 @mydea @lforst