Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Feb 16, 2024

Adds exclusive_time and measurements as fields to the Span class. Drops measurements from Transactions since it is now inherited from spans.

Note: this changes SpanAttributes type and allows Measurements as a value

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.6 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.82 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.76 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.44 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.79 KB (+0.5% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.7 KB (+0.5% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.38 KB (+0.02% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.39 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped) 22.67 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.85 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.33 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.13 KB (+0.3% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.07 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 215.33 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 103.13 KB (+0.34% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.28 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.3 KB (+0.29% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.19 KB (+0.24% 🔺)
@sentry/react - Webpack (gzipped) 22.7 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.91 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 52.11 KB (+0.32% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.24 KB (0%)

@edwardgou-sentry
Copy link
Contributor Author

This will be used in standalone INP spans

| Array<null | undefined | number>
| Array<null | undefined | boolean>;
| Array<null | undefined | boolean>
| Measurements;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks OTEL compatibility unfortunately. We'll just add them to span data directly for now, but we need a bigger strategy afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we'll probably have to flatten measurements into the attributes, or something similar in the future

@edwardgou-sentry edwardgou-sentry merged commit 3f5b962 into v7 Feb 29, 2024
@edwardgou-sentry edwardgou-sentry deleted the egou/v7/feat/add-exclusive-time-and-measurements-to-spans branch February 29, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants