feat(performance): create Interaction standalone spans on inp events #10709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com:getsentry/sentry-javascript into egou/v7/feat/add-span-envelope-and-datacategory
…ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/add-span-envelope-and-datacategory
| startTimestamp: startTime, | ||
| endTimestamp: startTime + duration, | ||
| op: 'ui.interaction.click', | ||
| name: entry.target?.nodeName, |
There was a problem hiding this comment.
I don't think nodeName is correct. Need to update this to get some identifier for the target interaction element
| }, | ||
| release, | ||
| environment, | ||
| transaction: routeName, |
There was a problem hiding this comment.
Passing the origin route name of the interaction as transaction
…/v7/feat/create-interaction-spans-on-inp
…:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
…ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
…hub.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
…hub.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
size-limit report 📦
|
…/v7/feat/create-interaction-spans-on-inp
…ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
…ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
…/v7/feat/create-interaction-spans-on-inp
…com:getsentry/sentry-javascript into egou/v7/profile-replay-and-user-for-inp
AbhiPrasad
approved these changes
Feb 29, 2024
…P spans (#10849) Adds profile id, replay id, and user to standalone INP spans. User comes from the current scope. Replay Id is retrieved from the relay integration module and calling getReplayId(). Profile Id is retrieved from getting the active transaction at the time of the interaction Since profile id isn't added to the transaction until the transaction ends, we need to hold onto a reference to the transaction instead of trying to grab the profile id right away
…, profile id, and user. Updates INP spans to check for sampling rate, similar to transactions. Also Adds profile id, replay id, and user to standalone INP spans. User comes from the current scope. Replay Id is retrieved from the relay integration module and calling getReplayId(). Profile Id is retrieved from getting the active transaction at the time of the interaction Since profile id isn't added to the transaction until the transaction ends, we need to hold onto a reference to the transaction instead of trying to grab the profile id right away
…/v7/feat/create-interaction-spans-on-inp
edwardgou-sentry
deleted the
egou/v7/feat/create-interaction-spans-on-inp
branch
|
small note for the next time, please make sure to squash and merge! (we sadly cannot disallow merge commits for now because we need it for gitflow 😬 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates standalone span when
onINPis triggered, and sends the span to sentry. AnInteractionRouteNameMappingis maintained to get the origin route name of the candidate INP span. The mapping is capped at 10 entries to minimize memory.Requires the following PRs
#10702
#10704
#10706