fix(node): support undici headers as strings or arrays #10938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Change looks good to me! Actually we should include this regardless because we want to support all possible Undici versions. |
|
I also opened an issue here: gas-buddy/opentelemetry-instrumentation-fetch-node#14 to ensure this can also be handled there! |
AbhiPrasad
approved these changes
Mar 7, 2024
Closed
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 7, 2024
This was referenced Mar 12, 2024
TBonnin
added a commit
to NangoHQ/nango
that referenced
this pull request
Apr 11, 2024
undici version was bumped yesterday but the sentry lib version 7.105 doesn't support it. Bumping sentry to 7.106 where the issue was fixed. https://github.com/getsentry/sentry-javascript/releases/tag/7.106.0 getsentry/sentry-javascript#10938
3 tasks
TBonnin
added a commit
to NangoHQ/nango
that referenced
this pull request
Apr 11, 2024
undici version was bumped yesterday but the sentry lib version 7.105 doesn't support it. Bumping sentry to 7.106 where the issue was fixed. https://github.com/getsentry/sentry-javascript/releases/tag/7.106.0 getsentry/sentry-javascript#10938
TBonnin
added a commit
to NangoHQ/nango
that referenced
this pull request
Apr 11, 2024
undici version was bumped yesterday but the sentry lib version 7.105 doesn't support it. Bumping sentry to 7.106 where the issue was fixed. https://github.com/getsentry/sentry-javascript/releases/tag/7.106.0 getsentry/sentry-javascript#10938
TBonnin
added a commit
to NangoHQ/nango
that referenced
this pull request
Apr 11, 2024
undici version was bumped yesterday but the sentry lib version 7.105 doesn't support it. Bumping sentry to 7.106 where the issue was fixed. https://github.com/getsentry/sentry-javascript/releases/tag/7.106.0 getsentry/sentry-javascript#10938
TBonnin
added a commit
to NangoHQ/nango
that referenced
this pull request
Apr 11, 2024
undici version was bumped yesterday but the sentry lib version 7.105 doesn't support it. Bumping sentry to 7.106 where the issue was fixed. https://github.com/getsentry/sentry-javascript/releases/tag/7.106.0 getsentry/sentry-javascript#10938 ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] I added observability, otherwise the reason is: - [ ] I added analytics, otherwise the reason is:
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).