ref(feedback): Refactor Feedback types into @sentry/types and reduce the exported surface area #11355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 561.53kB ⬇️
|
AbhiPrasad
reviewed
Apr 2, 2024
AbhiPrasad
approved these changes
Apr 3, 2024
size-limit report 📦
|
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…the exported surface area (getsentry#11355) You can read this commit-by-commit to watch the refactor unfold The situation is: after getsentry#11342 is merged, all the code inside each of the `packages/feedback/src/[core|modal|screenshot]` will be split up into separate integrations. These integrations can't share the same `src/types/*.ts` definitions anymore. Therefore type definitions will need to live in @sentry/types instead. This PR moves all the types, and since they'll be public now in that package, i refactored things to reduce the public surface area and improve names where possible. The only non-type changes in here are where we move `createDialog.ts` and `createInput.ts` into their respective `integration.ts` files, no code changes at all. Related to getsentry#11435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can read this commit-by-commit to watch the refactor unfold
The situation is: after #11342 is merged, all the code inside each of the
packages/feedback/src/[core|modal|screenshot]will be split up into separate integrations. These integrations can't share the samesrc/types/*.tsdefinitions anymore. Therefore type definitions will need to live in @sentry/types instead.This PR moves all the types, and since they'll be public now in that package, i refactored things to reduce the public surface area and improve names where possible.
The only non-type changes in here are where we move
createDialog.tsandcreateInput.tsinto their respectiveintegration.tsfiles, no code changes at all.Related to #11435