Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): Refactor Feedback types into @sentry/types and reduce the exported surface area #11355

Merged
merged 34 commits into from
Apr 8, 2024
Merged

ref(feedback): Refactor Feedback types into @sentry/types and reduce the exported surface area #11355

merged 34 commits into from
Apr 8, 2024

Commits on Mar 31, 2024

  1. Move feedback/src/types into types/feedback

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    ca3857a View commit details
    Browse the repository at this point in the history

  2. dedupe import statements

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    371df70 View commit details
    Browse the repository at this point in the history

  3. type the sendFeedback function

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    f20c39a View commit details
    Browse the repository at this point in the history

  4. streamline modal & screenshot integration files

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    e436fd4 View commit details
    Browse the repository at this point in the history

  5. type the createInput function

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    d7ced60 View commit details
    Browse the repository at this point in the history

  6. type FeedbackScreenshotIntegration

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    8be9dfa View commit details
    Browse the repository at this point in the history

  7. type FeedbackCreateDialog

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    3716f4c View commit details
    Browse the repository at this point in the history

  8. type FeedbackModalIntegration

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    5871a2e View commit details
    Browse the repository at this point in the history

  9. remove extra FeedbackTheme types

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    f4642ae View commit details
    Browse the repository at this point in the history

  10. move OptionalFeedbackConfiguration type into feedback/core

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    fd9c8f5 View commit details
    Browse the repository at this point in the history

  11. move OverrideFeedbackConfiguration into feedback/core

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    6a3c98d View commit details
    Browse the repository at this point in the history

  12. rename Dialog to FeedbackDialog

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    87b4b7b View commit details
    Browse the repository at this point in the history

  13. replace ScreenshotInput type with ReturnType<FeedbackCreateInputElement>

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    1684fc3 View commit details
    Browse the repository at this point in the history

  14. remove IFeedbackIntegration type

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    6063d2d View commit details
    Browse the repository at this point in the history

  15. consolidate SendFeedback into the sendFeedback.ts type file

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    e8231a2 View commit details
    Browse the repository at this point in the history

  16. sort exports

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    fb1cce9 View commit details
    Browse the repository at this point in the history

  17. remove FeedbackCreateInputElement

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    3443fc0 View commit details
    Browse the repository at this point in the history

  18. remove FeedbackCreateDialog

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    cc7056d View commit details
    Browse the repository at this point in the history

  19. install preact as a dev-dependency in @sentry/types

    @ryan953
    ryan953 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    a7cd4e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'develop' into ryan953/feedback-types

    @ryan953
    ryan953 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    32e23f1 View commit details
    Browse the repository at this point in the history

  2. remove preact from packages/types

    @ryan953
    ryan953 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    419cf15 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch 'develop' into ryan953/feedback-types

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c66d4d9 View commit details
    Browse the repository at this point in the history

  2. @sentry/types does not bring in html dom definitions, so ShadowRoot i… 

    …snt working
    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    586896b View commit details
    Browse the repository at this point in the history

  3. export function prop types to make TS happier

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2df3954 View commit details
    Browse the repository at this point in the history

  4. convert from unknowns to preact types inside feedback integrations

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    406332b View commit details
    Browse the repository at this point in the history

  5. more specific types

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a8bd246 View commit details
    Browse the repository at this point in the history

  6. alias unknown, so we can tell what it is meant to be

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4eab59e View commit details
    Browse the repository at this point in the history

  7. spell out the createInput return type

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3c2235f View commit details
    Browse the repository at this point in the history

  8. rm extra import

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2d18b07 View commit details
    Browse the repository at this point in the history

  9. ComponentType and inline checks seem to work better

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a0b907f View commit details
    Browse the repository at this point in the history

  10. use any

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3710c04 View commit details
    Browse the repository at this point in the history

  11. disambiguate screenshotInput and ScreenshotInput

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    481770b View commit details
    Browse the repository at this point in the history

  12. set type HTMLElement = unknown; for deno

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    98614a0 View commit details
    Browse the repository at this point in the history

  13. reset to HTMLElement at callsites

    @ryan953
    ryan953 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4d7618c View commit details
    Browse the repository at this point in the history