feat(aws-serverless): Fix tree-shaking for aws-serverless package #12017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
This was referenced May 14, 2024
timfish
approved these changes
May 14, 2024
Lms24
approved these changes
May 14, 2024
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
…2017) The prior fix was incomplete, because we were still using `getDefaultIntegrations()` inside of node's `init`, so the deps where pulled in anyhow. Furthermore, it seems that `preserveModules: false` for `@sentry/node` also prevented this from working as expected. So this PR does two things: 1. Set `preserveModules: true` so that tree-shaking can work as expected (😿 ) 2. Expose a new `initWithoutDefaultIntegrations` method from `@sentry/node` which AWS uses, which avoids including any integrations by default. You have to pass your own `defaultIntegrations` to it. This is not the prettiest solution, but I couldn't think of anything much better 😬 I also added a size-limit entry to keep track of this.
Lms24
added a commit
that referenced
this pull request
May 16, 2024
We previously adjusted our lambda layer auto initialization in #12017. This unfortunately changed the build output of the `awslambda-auto` bootstrapping script which required a package that isn't included in the layer (`@sentry/node`). This PR fixes the `awslambda-auto` file; local testing showed no more imports from `@sentry/node`. fixes #12074
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior fix was incomplete, because we were still using
getDefaultIntegrations()inside of node'sinit, so the deps where pulled in anyhow.Furthermore, it seems that
preserveModules: falsefor@sentry/nodealso prevented this from working as expected.So this PR does two things:
preserveModules: trueso that tree-shaking can work as expected (😿 )initWithoutDefaultIntegrationsmethod from@sentry/nodewhich AWS uses, which avoids including any integrations by default. You have to pass your owndefaultIntegrationsto it.This is not the prettiest solution, but I couldn't think of anything much better 😬 I also added a size-limit entry to keep track of this.