-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-serverless): Fix build of lambda layer #12083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
May 16, 2024
@@ -1,5 +1,4 @@ | |||
import { getDefaultIntegrations as getNodeDefaultIntegrations } from '@sentry/node'; | |||
import { init, tryPatchHandler } from './sdk'; | |||
import * as Sentry from './index'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this back to how we imported the actual SDK in v7
3 tasks
Lms24
changed the title
fix(aws-serverless): Fix build for lambda layer
fix(aws-serverless): Fix build of lambda layer
May 16, 2024
mydea
approved these changes
May 16, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously adjusted our lambda layer auto initialization in #12017. This unfortunately changed the build output of the
awslambda-auto
bootstrapping script which required a package that isn't included in the layer (@sentry/node
). This PR fixes theawslambda-auto
file; local testing showed no more imports from@sentry/node
.fixes #12074