Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(v7/loader): Update Loader Script to latest #12765

Merged
merged 2 commits into from
Jul 25, 2024
Merged

test(v7/loader): Update Loader Script to latest #12765

merged 2 commits into from
Jul 25, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 4, 2024

Backports the loader changes (as the loader also needs to run in v7).

Implements the changes from https://github.com/getsentry/sentry/compare/fn/loader-v8

Part of #12187

@mydea mydea self-assigned this Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.83 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.77 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.38 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.64 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.53 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.6 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.61 KB (0%)
@sentry/browser - Webpack (gzipped) 22.78 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79.05 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.38 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.06 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.29 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.51 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.1 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.83 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.34 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.27 KB (0%)
@sentry/react - Webpack (gzipped) 22.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90.03 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 54.15 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (+0.01% 🔺)

@mydea mydea mentioned this pull request Jul 4, 2024
Merged
mydea added a commit to getsentry/sentry that referenced this pull request Jul 8, 2024
@mydea
feat: Update Loader script to be v8 compatible (#73831)
d5e3525 
This updates the Loader Script to ensure we also check for an already
installed instance of the SDK under v8, where the global carrier
`window.__SENTRY__` has a different shape.

Part of getsentry/sentry-javascript#12187

* Tests for v8:
getsentry/sentry-javascript#12764
* Tests for v7:
getsentry/sentry-javascript#12765
@mydea mydea marked this pull request as ready for review July 8, 2024 13:53
@mydea mydea requested review from lforst, AbhiPrasad and chargome July 8, 2024 13:54
priscilawebdev pushed a commit to getsentry/sentry that referenced this pull request Jul 11, 2024
@mydea @priscilawebdev
feat: Update Loader script to be v8 compatible (#73831)
69e3201 
This updates the Loader Script to ensure we also check for an already
installed instance of the SDK under v8, where the global carrier
`window.__SENTRY__` has a different shape.

Part of getsentry/sentry-javascript#12187

* Tests for v8:
getsentry/sentry-javascript#12764
* Tests for v7:
getsentry/sentry-javascript#12765
@mydea mydea force-pushed the fn/v7-loader-script branch from f9c359a to d922a6a Compare July 25, 2024 12:59
@mydea mydea merged commit eeae3cf into v7 Jul 25, 2024
75 checks passed
@mydea mydea deleted the fn/v7-loader-script branch July 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric approved these changes

@lforst lforst Awaiting requested review from lforst

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

@chargome chargome Awaiting requested review from chargome

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @cleptric