Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Loader Script to support v8 #12187

Closed
3 of 4 tasks
rodolfoBee opened this issue May 23, 2024 · 9 comments · Fixed by getsentry/sentry#75818
Closed
3 of 4 tasks

Update the Loader Script to support v8 #12187

rodolfoBee opened this issue May 23, 2024 · 9 comments · Fixed by getsentry/sentry#75818
Assignees
@mydea
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug

Comments

@rodolfoBee
Copy link
Member

rodolfoBee commented May 23, 2024 •
edited by mydea
Loading

Today, the Loader Script defaults to & supports v7 of the SDK.

We want to also support v8 there. We should implement this in a few steps:

Tasks
Preview Give feedback
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 May 23, 2024
@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label May 23, 2024
@Lms24 Lms24 mentioned this issue May 23, 2024
Closed
@Lms24
Copy link
Member

Lms24 commented May 23, 2024

This is on our radar but we held off from it with the initial 8.0.0 launch to reduce the number of moving parts. We're aware and will tackle this soon (TM)

@lforst
Copy link
Member

lforst commented May 23, 2024

All of this is prepared, we just need to flip the switch when we feel like we are ready.

@Lms24
Copy link
Member

Lms24 commented May 23, 2024

The loader script is blocked on #12188

@AbhiPrasad AbhiPrasad mentioned this issue May 24, 2024
Closed
@mydea mydea changed the title Release v8 for loader script Update the Loader Script to support v8 Jun 18, 2024
This was referenced Jul 4, 2024
Merged
Merged
Merged
Merged
Merged
mydea added a commit to getsentry/sentry that referenced this issue Jul 8, 2024
@mydea
feat: Update Loader script to be v8 compatible (#73831)
d5e3525 
This updates the Loader Script to ensure we also check for an already
installed instance of the SDK under v8, where the global carrier
`window.__SENTRY__` has a different shape.

Part of getsentry/sentry-javascript#12187

* Tests for v8:
getsentry/sentry-javascript#12764
* Tests for v7:
getsentry/sentry-javascript#12765
mydea added a commit to getsentry/sentry that referenced this issue Jul 9, 2024
@mydea
feat(ui): Update Loader Script UI to accomodate v8 (#73836)
30e129f 
This updates the UI of the loader script settings to accomodate v8.

Part of getsentry/sentry-javascript#12187
mydea added a commit that referenced this issue Jul 9, 2024
@mydea
test(loader): Update Loader Script to latest (#12764)
25db805 
Implements the changes from
https://github.com/getsentry/sentry/compare/fn/loader-v8?expand=1

Part of #12187
@mydea mydea self-assigned this Jul 9, 2024
mydea added a commit to getsentry/sentry that referenced this issue Jul 9, 2024
@mydea
feat: Allow to select v8 in Loader Script (#73835)
12daf60 
This adds a feature flag `organizations:js-sdj-loader-v8` that can be
set that will add `8.x` to the selectable options for the Loader Script.

Part of getsentry/sentry-javascript#12187
priscilawebdev pushed a commit to getsentry/sentry that referenced this issue Jul 11, 2024
@mydea @priscilawebdev
feat: Update Loader script to be v8 compatible (#73831)
69e3201 
This updates the Loader Script to ensure we also check for an already
installed instance of the SDK under v8, where the global carrier
`window.__SENTRY__` has a different shape.

Part of getsentry/sentry-javascript#12187

* Tests for v8:
getsentry/sentry-javascript#12764
* Tests for v7:
getsentry/sentry-javascript#12765
priscilawebdev pushed a commit to getsentry/sentry that referenced this issue Jul 11, 2024
@mydea @priscilawebdev
feat(ui): Update Loader Script UI to accomodate v8 (#73836)
7cdf57c 
This updates the UI of the loader script settings to accomodate v8.

Part of getsentry/sentry-javascript#12187
priscilawebdev pushed a commit to getsentry/sentry that referenced this issue Jul 11, 2024
@mydea @priscilawebdev
feat: Allow to select v8 in Loader Script (#73835)
a48999a 
This adds a feature flag `organizations:js-sdj-loader-v8` that can be
set that will add `8.x` to the selectable options for the Loader Script.

Part of getsentry/sentry-javascript#12187
@jgillard jgillard mentioned this issue Jul 15, 2024
Closed
@borisyordanov
Copy link

@rodolfoBee @Lms24 @lforst When will the CDN be available?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 19, 2024
@mydea
Copy link
Member

mydea commented Jul 19, 2024

We are currently testing the v8 version with the Loader, and expect to release it to the public soon! We'll keep you posted here.

@borisyordanov
Copy link

@mydea It's great to hear that you're making progress on this. Can you please clarify what "soon" means? A day? A week? A month?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 22, 2024
@mydea
Copy link
Member

mydea commented Jul 22, 2024

We hope to release this either this or next week, depending on how the testing goes!

mydea added a commit that referenced this issue Jul 25, 2024
@mydea
test(v7/loader): Update Loader Script to latest (#12765)
eeae3cf 
Backports the loader changes (as the loader also needs to run in v7).

Implements the changes from
https://github.com/getsentry/sentry/compare/fn/loader-v8

Part of #12187
@erikt9
Copy link

erikt9 commented Jul 26, 2024

Noting that v8 is available in my Sentry settings -- so seems to be live?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 26, 2024
@Lms24
Copy link
Member

Lms24 commented Jul 29, 2024

Hey @erikt9 yes it's live since a couple of days. We don't default to v8 being the preselected version yet but you can switch to it manually. Let us know if everything works for you!

@mydea mydea mentioned this issue Aug 8, 2024
Merged
@4bambi 4bambi mentioned this issue Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use v8 for Loader by default for new projects getsentry/sentry
6 participants
@mydea @lforst @Lms24 @borisyordanov @erikt9 @rodolfoBee