Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use v8 for Loader by default for new projects #75818

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 8, 2024

This PR removes the loader-v8 feature flag, instead enabling this for all orgs. It also adds a new epoch, so that new projects will get v8 by default for the loader. v7 remains selectable for them.

closes getsentry/sentry-javascript#12187

@mydea mydea requested review from lforst, AbhiPrasad and s1gr1d August 8, 2024 12:35
@mydea mydea self-assigned this Aug 8, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (7c32da1) to head (ec02194).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75818      +/-   ##
==========================================
+ Coverage   74.98%   78.24%   +3.25%     
==========================================
  Files        6816     6818       +2     
  Lines      303513   303696     +183     
  Branches    52210    52236      +26     
==========================================
+ Hits       227583   237617   +10034     
+ Misses      69185    59689    -9496     
+ Partials     6745     6390     -355     
Files Coverage Δ
src/sentry/features/temporary.py 100.00% <ø> (ø)
src/sentry/loader/browsersdkversion.py 85.24% <100.00%> (+2.16%) ⬆️
src/sentry/projectoptions/defaults.py 100.00% <100.00%> (ø)

... and 682 files with indirect coverage changes

@mydea mydea force-pushed the fn/loader-v8-default branch from ec02194 to 66affc2 Compare August 12, 2024 08:45
@mydea mydea merged commit 8ef7198 into master Aug 12, 2024
48 checks passed
@mydea mydea deleted the fn/loader-v8-default branch August 12, 2024 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Loader Script to support v8
2 participants