Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Skip patching when breadcrumbs are disabled #15733

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chargome
Copy link
Member

If I understood this correctly we can save some work when breadcrumbs are disabled as the only outcome here is addRequestBreadcrumb(request, response); anyway

ref #15725

@chargome chargome requested a review from mydea March 19, 2025 12:09
@mydea
Copy link
Member

mydea commented Mar 19, 2025

Currently, yes, but this will not be true anymore wenn this: #15735 is merged. but we can still check for multiple conditions then and avoid adding the instrumentation when we know it would do nothing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants