Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Skip patching when breadcrumbs are disabled #15733

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat(node): Skip patching when breadcrumbs are disabled #15733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/node/src/integrations/http/SentryHttpInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
// eslint-disable-next-line @typescript-eslint/no-this-alias
const instrumentation = this;

const _breadcrumbs = instrumentation.getConfig().breadcrumbs;
const breadcrumbsEnabled = typeof _breadcrumbs === 'undefined' ? true : _breadcrumbs;

// Skip work here when breadcrumbs are disabled
if (!breadcrumbsEnabled) {
return original => original;
}

return (original: (...args: unknown[]) => http.ClientRequest): ((...args: unknown[]) => http.ClientRequest) => {
return function outgoingRequest(this: unknown, ...args: unknown[]): http.ClientRequest {
instrumentation._diag.debug('http instrumentation for outgoing requests');
Expand All @@ -227,16 +235,13 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
const request = original.apply(this, args) as ReturnType<typeof http.request>;

request.prependListener('response', (response: http.IncomingMessage) => {
const _breadcrumbs = instrumentation.getConfig().breadcrumbs;
const breadCrumbsEnabled = typeof _breadcrumbs === 'undefined' ? true : _breadcrumbs;

const _ignoreOutgoingRequests = instrumentation.getConfig().ignoreOutgoingRequests;
const shouldCreateBreadcrumb =
typeof _ignoreOutgoingRequests === 'function'
? !_ignoreOutgoingRequests(getRequestUrl(request), optionsParsed)
: true;

if (breadCrumbsEnabled && shouldCreateBreadcrumb) {
if (shouldCreateBreadcrumb) {
addRequestBreadcrumb(request, response);
}
});
Expand Down
Loading