fix(node): Update version range for module.register
#16125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Node 21 to the accepted version range for
module.register
as it is already supported (https://nodejs.org/docs/v21.0.0/api/module.html).This also causes the customization hook not to call register (maybe a reason why some packages in issue #14202 are not instrumented):
sentry-javascript/packages/node/src/sdk/initOtel.ts
Lines 45 to 65 in 59094af
Additionally, the above mentioned issue #14202 shows the following warning although it's using v21: