feat(node): Drop http.server spans with 404 status by default
#16205
+232
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
This can be configured via `dropSpansForIncomingRequestStatusCodes` option in `httpIntegration()`.
lforst
reviewed
May 7, 2025
| transport: loggingTransport, | ||
| integrations: [ | ||
| Sentry.httpIntegration({ | ||
| dropSpansForIncomingRequestStatusCodes: [499, /3\d{2}/], |
There was a problem hiding this comment.
The regex is an interesting API choice. I can kindof see the reason, just wanna suggest other options that might be a bit more intuitive to write and don't require googling what the regex for numbers is, like:
- Providing intervals to drop for ranges like
[from, to]e.g.[400, 499]. - Providing strings with
xas a wildcard e.g."4xx"
There was a problem hiding this comment.
yeah, I know what you mean. The drop ranges seem fine to me too, I'll adjust it to that instead!
lforst
approved these changes
May 7, 2025
mydea
commented
May 7, 2025
| @@ -125,20 +125,3 @@ test('Should send a transaction event with correct status for a generateMetadata | |||
|
|
|||
| expect((await transactionPromise).contexts?.trace?.status).toBe('ok'); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
@lforst removed this test as this is no longer sent
lforst
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be configured like this:
It defaults to
[404].Closes #16193