fix(apm): Sampling of traces #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set op otherwise span will be discarded by the server
dashed
approved these changes
Mar 18, 2020
rhcarvalho
reviewed
Mar 18, 2020
| @@ -402,6 +402,8 @@ export class Tracing implements Integration { | |||
|
|
|||
| const span = hub.startSpan( | |||
| { | |||
| op: 'operation', | |||
| sampled: true, | |||
There was a problem hiding this comment.
FTR (as we talked over video chat), I believe more users will forget to set this and get surprised and frustrated.
It feels like only the SDK itself should ever set the valued of sampled, never the user.
HazAT
changed the title
|
This is the docs pr |
rhcarvalho
reviewed
Mar 18, 2020
packages/apm/src/hubextensions.ts
Outdated
| const experimentsOptions = (client && client.getOptions()._experiments) || {}; | ||
| span.initFinishedSpans(experimentsOptions.maxSpans as number); | ||
| } | ||
| // We always want to record spans independent from the sample rate |
There was a problem hiding this comment.
Could you please add a short summary of why?
rhcarvalho
reviewed
Mar 18, 2020
rhcarvalho
reviewed
Mar 18, 2020
rhcarvalho
reviewed
Mar 18, 2020
rhcarvalho
reviewed
Mar 18, 2020
rhcarvalho
reviewed
Mar 18, 2020
rhcarvalho
reviewed
Mar 18, 2020
Co-Authored-By: Rodolfo Carvalho <rodolfo.carvalho@sentry.io>
rhcarvalho
reviewed
Mar 18, 2020
Co-Authored-By: Rodolfo Carvalho <rodolfo.carvalho@sentry.io>
Co-Authored-By: Rodolfo Carvalho <rodolfo.carvalho@sentry.io>
…ipt into apm/set-sampled
untitaker
reviewed
Mar 19, 2020
| @@ -187,7 +192,10 @@ export class Span implements SpanInterface, SpanContext { | |||
| traceId: this._traceId, | |||
| }); | |||
|
|
|||
| span.spanRecorder = this.spanRecorder; | |||
There was a problem hiding this comment.
This is already happening in finishSpan
rhcarvalho
approved these changes
Mar 19, 2020
This was referenced Mar 23, 2020
This was referenced Apr 12, 2020
This was referenced Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking the sampling decision, now everything is consistent with it was meant to be.
tracesSampleRateforceNoChildparameter fromhub.startSpanSpaninternal, only usehub.startSpan