Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apm): Sampling of traces #2500

Merged
merged 35 commits into from
Mar 19, 2020
Merged

fix(apm): Sampling of traces #2500

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
94a9e2e
fix(apm): Set sampled to true by default
HazAT Mar 18, 2020
a92c730
meta: Changelog
HazAT Mar 18, 2020
715bd45
fix(apm): Sampling
HazAT Mar 18, 2020
c82f1d8
ref: Remove set default op
HazAT Mar 18, 2020
7c8d803
fix: Sampling decision
HazAT Mar 18, 2020
895c188
ref: Add comment
HazAT Mar 18, 2020
b0870b6
ref: typo
HazAT Mar 18, 2020
a5b5f2b
ref: Changes to docblock
HazAT Mar 18, 2020
2c662dc
ref: Change message
HazAT Mar 18, 2020
b96e512
Apply suggestions from code review
HazAT Mar 18, 2020
4139da7
Update packages/types/src/options.ts
HazAT Mar 18, 2020
5a66e0b
Update packages/types/src/options.ts
HazAT Mar 18, 2020
450259e
ref: Remove deprecated parts
HazAT Mar 18, 2020
b29a8b4
Merge branch 'apm/set-sampled' of github.com:getsentry/sentry-javascr…
HazAT Mar 18, 2020
86ce10f
fix: Maxlen
HazAT Mar 18, 2020
a1b2496
ref: Rework when and how integrations are setup
HazAT Mar 18, 2020
ea581e7
ref(apm): Send a span if it's not a child
HazAT Mar 18, 2020
3583578
ref: Tracing integration
HazAT Mar 18, 2020
2bbd2e7
fix: tests
HazAT Mar 18, 2020
c3f2750
fix: Span / Transaction creation
HazAT Mar 18, 2020
de8fefa
ref: CodeReview
HazAT Mar 18, 2020
29f392e
fix: Setup integrations when after we bound a client to the hub
HazAT Mar 18, 2020
878a8fc
ref: CodeReview
HazAT Mar 18, 2020
a2733e6
fix: tests
HazAT Mar 18, 2020
74a9894
Update packages/types/src/span.ts
HazAT Mar 18, 2020
319fe10
Merge branch 'apm/set-sampled' of github.com:getsentry/sentry-javascr…
HazAT Mar 18, 2020
4332b35
ref: CodeReview
HazAT Mar 18, 2020
7a114f5
ref: CodeReview
HazAT Mar 18, 2020
a695cd9
fix: Tests
HazAT Mar 18, 2020
498e3ff
ref: Refactor SpanRecorder -> SpanList
HazAT Mar 19, 2020
26bee09
ref: Rename back to SpanRecorder to be consistent with Python
HazAT Mar 19, 2020
a2351ab
ref: SpanRecorder
HazAT Mar 19, 2020
0ad436e
ref: Remove makeRoot
HazAT Mar 19, 2020
6d471b9
ref: Changelog
HazAT Mar 19, 2020
106905d
meta: Changelog
HazAT Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- [apm] fix: Set sampled and op by default (#2500)
- [apm] ref: Remove status from tags in transaction (#2497)
- [browser] fix: Respect breadcrumbs sentry:false option (#2499)

## 5.14.2

- [apm] fix: Use Performance API for timings when available, including Web Workers (#2492)
Expand Down
2 changes: 2 additions & 0 deletions packages/apm/src/integrations/tracing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,8 @@ export class Tracing implements Integration {

const span = hub.startSpan(
{
op: 'operation',
sampled: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR (as we talked over video chat), I believe more users will forget to set this and get surprised and frustrated.
It feels like only the SDK itself should ever set the valued of sampled, never the user.

...spanContext,
transaction: name,
},
Expand Down