Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): Add TS3.8 compile test #8955

Merged
merged 22 commits into from
Sep 12, 2023
Merged

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Sep 6, 2023

Adds project that fails to compile if downleveled types of its deps are not TS3.8 compatible.

Screenshot 2023-09-06 at 10 46 15

@krystofwoldrich
Copy link
Member Author

It's the same test as we have in sentry-react-native, there it's a bit simple as it's only one project. If there is better solution for monorepos I'm open to ideas.

@lforst
Copy link
Member

lforst commented Sep 6, 2023

Can we do this as an E2E test instead? I like the idea tho.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.38 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.31 KB (0%)
@sentry/browser - Webpack (gzipped) 21.91 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.16 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.5 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.59 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.75 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.13 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.37 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.4 KB (0%)
@sentry/react - Webpack (gzipped) 21.94 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.27 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.88 KB (0%)

Base automatically changed from kw-fix-downleveled-types to develop September 6, 2023 10:09
@krystofwoldrich
Copy link
Member Author

The test passed, it's ready for another review.

@AbhiPrasad AbhiPrasad merged commit cfc2333 into develop Sep 12, 2023
80 checks passed
@AbhiPrasad AbhiPrasad deleted the kw-add-ts-3-8-compile-test branch September 12, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants